Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 200603002: Refactor FastTextAutosizer to remove the TextAutosizer dependencies (Closed)

Created:
6 years, 9 months ago by pdr.
Modified:
6 years, 9 months ago
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr.
Visibility:
Public.

Description

Refactor FastTextAutosizer to remove the TextAutosizer dependencies This patch copies TextAutosizer's functions into FastTextAutosizer.cpp so that we can refactor this code for understandability. This is the first patch of a few and just moves the code. A followup will actually refactor the functions. BUG=302005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169387

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -14 lines) Patch
M Source/core/rendering/FastTextAutosizer.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/FastTextAutosizer.cpp View 1 2 9 chunks +188 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pdr.
6 years, 9 months ago (2014-03-14 18:20:21 UTC) #1
skobes
lgtm
6 years, 9 months ago (2014-03-17 18:39:35 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-17 18:58:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/200603002/40001
6 years, 9 months ago (2014-03-17 18:58:20 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-17 18:59:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-17 18:59:51 UTC) #6
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-17 20:00:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/200603002/40001
6 years, 9 months ago (2014-03-17 20:00:38 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-17 20:32:28 UTC) #9
Message was sent while issue was closed.
Change committed as 169387

Powered by Google App Engine
This is Rietveld 408576698