Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2006023005: Disable fullscreen global permission setting in Android. (Closed)

Created:
4 years, 7 months ago by Matt Giuca
Modified:
4 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Disable fullscreen global permission setting in Android. Fixes a bug where fullscreen *looks* disableable but it's actually always permitted by default. Forces the global slider to always be turned on (the user cannot switch it to the off position), and changes the string from "Allowed" to "Always allowed" to communicate that it cannot be disabled. This is a stop-gap measure until we can delete the data (and then this setting UI will be removed entirely). See bug for details. Only applies when the simplified-fullscreen-ui flag is enabled (which it is by default). BUG=611327 Review-Url: https://codereview.chromium.org/1989303005 Cr-Commit-Position: refs/heads/master@{#395513} (cherry picked from commit 827ed475ee038454ee7dfb2cadba17568fc4a2b5) Committed: https://chromium.googlesource.com/chromium/src/+/73a4b14217bc2d96e41b80c1ec85b1478d96c383

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleCategoryPreferences.java View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
4 years, 7 months ago (2016-05-24 03:34:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73a4b14217bc2d96e41b80c1ec85b1478d96c383.

Powered by Google App Engine
This is Rietveld 408576698