Log some information about the state of the homepage on Android.

chrome/browser/prefs/pref_metrics_service.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/prefs/pref_metrics_service.h"
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 60 matching lines @@
                                        PrefService* local_state)
     : profile_(profile),
       prefs_(profile->GetPrefs()),
       local_state_(local_state),
       weak_factory_(this) {
 }
 
 PrefMetricsService::~PrefMetricsService() {
 }
 
-void PrefMetricsService::RecordLaunchPrefs() {
-  bool show_home_button = prefs_->GetBoolean(prefs::kShowHomeButton);
-  bool home_page_is_ntp = prefs_->GetBoolean(prefs::kHomePageIsNewTabPage);
+// static
+void PrefMetricsService::RecordHomePageLaunchMetrics(bool show_home_button,
+                                                     bool homepage_is_ntp,
+                                                     const GURL& homepage_url) {
   UMA_HISTOGRAM_BOOLEAN("Settings.ShowHomeButton", show_home_button);
   if (show_home_button) {
     UMA_HISTOGRAM_BOOLEAN("Settings.GivenShowHomeButton_HomePageIsNewTabPage",
-                          home_page_is_ntp);
+                          homepage_is_ntp);
   }
 
   // For non-NTP homepages, see if the URL comes from the same TLD+1 as a known
   // search engine.  Note that this is only an approximation of search engine
   // use, due to both false negatives (pages that come from unknown TLD+1 X but
   // consist of a search box that sends to known TLD+1 Y) and false positives
   // (pages that share a TLD+1 with a known engine but aren't actually search
   // pages, e.g. plus.google.com).  Additionally, record the TLD+1 of non-NTP
   // homepages through the privacy-preserving Rappor service.
-  if (!home_page_is_ntp) {
-    GURL homepage_url(prefs_->GetString(prefs::kHomePage));
+  if (!homepage_is_ntp) {
     if (homepage_url.is_valid()) {
       UMA_HISTOGRAM_ENUMERATION(
           "Settings.HomePageEngineType",
           TemplateURLPrepopulateData::GetEngineType(homepage_url),
           SEARCH_ENGINE_MAX);
       rappor::SampleDomainAndRegistryFromGURL(
           g_browser_process->rappor_service(), "Settings.HomePage2",
           homepage_url);
     }
   }
+}
 
+void PrefMetricsService::RecordLaunchPrefs() {

[gab, 2016/05/25 14:03:24]

How about #if !defined(OS_ANDROID) on this entire method (with a meta-comment
explaining why each subsection either doesn't apply to Android or is done later
on Android)? Seems weird to have many ifdef blocks that amount to an empty body
on Android.

[Mark P, 2016/05/25 17:01:53]

I know it looks weird, but (i) these are independent decisions so I think they
should look like independent decisions to people reading the code and (ii) when
someone comes to the code to glance at metrics recording, they usually only look
in the near vicinity, not, say, 50 lines up to see if there's an ifdef covering
something larger than what should be the single conceptual unit they're looking
at.  I like this current structure.

[gab, 2016/05/25 17:13:11]

Ok, works for me then.

+  // On Android, determining whether the homepage is enabled requires waiting
+  // for a response from a third party provider installed on the device.  So,
+  // it will be logged later once all the dependent information is available.
+  // See DeferredStartupHandler.java.
+#if !defined(OS_ANDROID)
+  GURL homepage_url(prefs_->GetString(prefs::kHomePage));
+  RecordHomePageLaunchMetrics(prefs_->GetBoolean(prefs::kShowHomeButton),
+                              prefs_->GetBoolean(prefs::kHomePageIsNewTabPage),
+                              homepage_url);
+#endif
+
+  // Android does not support overriding the NTP URL.
+#if !defined(OS_ANDROID)
   SampleNewTabPageURL(profile_);
+#endif
 
+  // Tab restoring is always done on Android, so these metrics are not
+  // applicable.  Also, startup pages are not supported on Android
+#if !defined(OS_ANDROID)
   int restore_on_startup = prefs_->GetInteger(prefs::kRestoreOnStartup);
   UMA_HISTOGRAM_ENUMERATION("Settings.StartupPageLoadSettings",
                             restore_on_startup, kSessionStartupPrefValueMax);
   if (restore_on_startup == SessionStartupPref::kPrefValueURLs) {
     const base::ListValue* url_list =
         prefs_->GetList(prefs::kURLsToRestoreOnStartup);
     UMA_HISTOGRAM_CUSTOM_COUNTS("Settings.StartupPageLoadURLs",
                                 url_list->GetSize(), 1, 50, 20);
     // Similarly, check startup pages for known search engine TLD+1s.
     std::string url_text;
     for (size_t i = 0; i < url_list->GetSize(); ++i) {
       if (url_list->GetString(i, &url_text)) {
         GURL start_url(url_text);
         if (start_url.is_valid()) {
           UMA_HISTOGRAM_ENUMERATION(
               "Settings.StartupPageEngineTypes",
               TemplateURLPrepopulateData::GetEngineType(start_url),
               SEARCH_ENGINE_MAX);
           if (i == 0) {
             rappor::SampleDomainAndRegistryFromGURL(
                 g_browser_process->rappor_service(),
                 "Settings.FirstStartupPage", start_url);
           }
         }
       }
     }
   }
+#endif
 
+  // Android does not support pinned tabs.
 #if !defined(OS_ANDROID)
   StartupTabs startup_tabs = PinnedTabCodec::ReadPinnedTabs(profile_);
   UMA_HISTOGRAM_CUSTOM_COUNTS("Settings.PinnedTabs",
                               startup_tabs.size(), 1, 50, 20);
   for (size_t i = 0; i < startup_tabs.size(); ++i) {
     GURL start_url(startup_tabs.at(i).url);
     if (start_url.is_valid()) {
       UMA_HISTOGRAM_ENUMERATION(
           "Settings.PinnedTabEngineTypes",
           TemplateURLPrepopulateData::GetEngineType(start_url),
@@ skipping 99 matching lines @@
 }
 
 bool PrefMetricsService::Factory::ServiceIsNULLWhileTesting() const {
   return false;
 }
 
 content::BrowserContext* PrefMetricsService::Factory::GetBrowserContextToUse(
     content::BrowserContext* context) const {
   return chrome::GetBrowserContextRedirectedInIncognito(context);
 }