Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: extensions/renderer/runtime_custom_bindings.cc

Issue 2006013002: [Extensions] Determine NativeMessaging ID solely on the browser process (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ;; Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/runtime_custom_bindings.cc
diff --git a/extensions/renderer/runtime_custom_bindings.cc b/extensions/renderer/runtime_custom_bindings.cc
index c7f9e279fde28af65d6d72a3525a5c6860393f8c..6efae5f182d9f925e92b55ad91cb6328439206e5 100644
--- a/extensions/renderer/runtime_custom_bindings.cc
+++ b/extensions/renderer/runtime_custom_bindings.cc
@@ -87,15 +87,11 @@ void RuntimeCustomBindings::OpenChannelToNativeApp(
if (!render_frame)
return;
- const std::string& extension_id = context()->GetExtensionID();
- // Should be caught by JS.
- CHECK(!extension_id.empty());
-
std::string native_app_name = *v8::String::Utf8Value(args[0]);
int port_id = -1;
render_frame->Send(new ExtensionHostMsg_OpenChannelToNativeApp(
- render_frame->GetRoutingID(), extension_id, native_app_name, &port_id));
+ render_frame->GetRoutingID(), native_app_name, &port_id));
args.GetReturnValue().Set(static_cast<int32_t>(port_id));
}
« no previous file with comments | « extensions/common/extension_messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698