content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 2005953002: [mac][views] Notify web_contents focused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2005953002: [mac][views] Notify web_contents focused. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 36b9717deac619b6671d4cd64270be76f304e9ef..e26d7a682b6dc3ce5428f6874360cedbc337876e 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -2726,7 +2726,7 @@ void RenderWidgetHostViewMac::OnDisplayMetricsChanged(

if (!renderWidgetHostView_->render_widget_host_)

return NO;

- renderWidgetHostView_->render_widget_host_->Focus();

+ renderWidgetHostView_->render_widget_host_->GotFocus();

Avi (use Gerrit) 2016/06/01 13:43:38 Was the call to Focus that used to be here wrong,

yamaxim 2016/06/01 14:23:55 yes Now: WebContentsViewMac::Focus() then Render

renderWidgetHostView_->SetTextInputActive(true);

// Cancel any onging composition text which was left before we lost focus.