[mac][views] Notify web_contents focused.

content/browser/web_contents/web_contents_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Carbon/Carbon.h>
 
 #import "content/browser/web_contents/web_contents_view_mac.h"
 
 #include <string>
 
@@ skipping 165 matching lines @@
   return rwhv ? rwhv->GetNativeView() : nil;
 }
 
 void WebContentsViewMac::Focus() {
   gfx::NativeView native_view = GetNativeViewForFocus();
   NSWindow* window = [native_view window];
   [window makeFirstResponder:native_view];
   if (![window isVisible])
     return;
   [window makeKeyAndOrderFront:nil];
+  GotFocus();

[Avi (use Gerrit), 2016/05/30 16:13:33]

Should this be necessary?

RenderViewHostImpl::RenderWidgetGotFocus() calls it, so shouldn't that work for
us too on the Mac?

[yamaxim, 2016/05/30 16:57:21]

It's not called for mac_views because WebContentsViewMac::Focus() differs from
WebContentsViewAura::Focus() that call rwhv->Focus

[tapted, 2016/05/31 12:01:50]

So I think we want this to be triggered by -[RenderWidgetHostViewCocoa
becomeFirstResponder].

That does:

- (BOOL)becomeFirstResponder {
  if (!renderWidgetHostView_->render_widget_host_)
    return NO;

  renderWidgetHostView_->render_widget_host_->Focus();
  / * etc */


I think we just need to change that call to Focus() to be GotFocus() instead.
Since the first thing RenderWidgetHostImpl::GotFocus() does is to call Focus()

 }
 
 void WebContentsViewMac::SetInitialFocus() {
   if (web_contents_->FocusLocationBarByDefault())
     web_contents_->SetFocusToLocationBar(false);
   else
     Focus();
 }
 
 void WebContentsViewMac::StoreFocus() {
@@ skipping 25 matching lines @@
   return [cocoa_view_ dropData];
 }
 
 void WebContentsViewMac::UpdateDragCursor(WebDragOperation operation) {
   [cocoa_view_ setCurrentDragOperation: operation];
 }
 
 void WebContentsViewMac::GotFocus() {
   // This is only used in the views FocusManager stuff but it bleeds through
   // all subclasses. http://crbug.com/21875
+  web_contents_->NotifyWebContentsFocused();
 }
 
 // This is called when the renderer asks us to take focus back (i.e., it has
 // iterated past the last focusable element on the page).
 void WebContentsViewMac::TakeFocus(bool reverse) {
   if (reverse) {
     [[cocoa_view_ window] selectPreviousKeyView:cocoa_view_.get()];
   } else {
     [[cocoa_view_ window] selectNextKeyView:cocoa_view_.get()];
   }
@@ skipping 438 matching lines @@
 
 - (void)viewDidHide {
   [self updateWebContentsVisibility];
 }
 
 - (void)viewDidUnhide {
   [self updateWebContentsVisibility];
 }
 
 @end