[wasm] globals size is not a per-instance property.

[wasm] globals size is not a per-instance property.

Moved globals offsets calculation to the wasm module decoder, since
this is a property of the module, not of each instance.

Qualified as "const" references to WasmModule outside of the decoder
and some test situations.

BUG=

Committed: https://crrev.com/6b8d17e325ab611bbf3814a86610ad7af8d94512
Cr-Commit-Position: refs/heads/master@{#36484}

[Mircea Trofin, 2016-05-23 22:03:07]

Description was changed from

==========
[wasm] globals size is not a per-instance property.

BUG=
==========

to

==========
[wasm] globals size is not a per-instance property.

Moved globals offsets calculation to the wasm module decoder, since
this is a property of the module, not of each instance.

Qualified as "const" references to WasmModule outside of the decoder
and some test situations.

BUG=
==========

[Mircea Trofin, 2016-05-23 22:03:07]

mtrofin@chromium.org changed reviewers:
+ titzer@chromium.org

[Mircea Trofin, 2016-05-23 22:03:23]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org

[titzer, 2016-05-24 08:32:01]

lgtm as long as those dang const qualifiers don't spread everywhere

https://codereview.chromium.org/2005933003/diff/60001/test/cctest/wasm/wasm-r...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/2005933003/diff/60001/test/cctest/wasm/wasm-r...
test/cctest/wasm/wasm-run-utils.h:528: return
&testing_module_->mutable_module()->functions[function_index_];
Why not introduce a method to get a non-const function instead of exposing the
mutable module?

[Mircea Trofin, 2016-05-24 14:57:01]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-05-24 14:57:01]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2005933003/#ps80001
(title: " ")

[Mircea Trofin, 2016-05-24 14:57:07]

https://codereview.chromium.org/2005933003/diff/60001/test/cctest/wasm/wasm-r...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/2005933003/diff/60001/test/cctest/wasm/wasm-r...
test/cctest/wasm/wasm-run-utils.h:528: return
&testing_module_->mutable_module()->functions[function_index_];
On 2016/05/24 08:32:01, titzer wrote:
> Why not introduce a method to get a non-const function instead of exposing the
> mutable module?

Done.

[commit-bot: I haz the power, 2016-05-24 14:57:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005933003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005933003/80001

[commit-bot: I haz the power, 2016-05-24 14:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 14:59:16]

Try jobs failed on following builders:
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2156)

[Mircea Trofin, 2016-05-24 15:19:24]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-05-24 15:19:25]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2005933003/#ps100001
(title: " ")

[commit-bot: I haz the power, 2016-05-24 15:19:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005933003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005933003/100001

[commit-bot: I haz the power, 2016-05-24 15:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 15:23:27]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6265)

[Mircea Trofin, 2016-05-24 16:00:57]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2016-05-24 16:00:57]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2005933003/#ps70009
(title: " ")

[commit-bot: I haz the power, 2016-05-24 16:01:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005933003/70009
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005933003/70009

[commit-bot: I haz the power, 2016-05-24 16:32:09]

Description was changed from

==========
[wasm] globals size is not a per-instance property.

Moved globals offsets calculation to the wasm module decoder, since
this is a property of the module, not of each instance.

Qualified as "const" references to WasmModule outside of the decoder
and some test situations.

BUG=
==========

to

==========
[wasm] globals size is not a per-instance property.

Moved globals offsets calculation to the wasm module decoder, since
this is a property of the module, not of each instance.

Qualified as "const" references to WasmModule outside of the decoder
and some test situations.

BUG=
==========

[commit-bot: I haz the power, 2016-05-24 16:32:11]

Committed patchset #7 (id:70009)

[commit-bot: I haz the power, 2016-05-24 16:34:00]

Description was changed from

==========
[wasm] globals size is not a per-instance property.

Moved globals offsets calculation to the wasm module decoder, since
this is a property of the module, not of each instance.

Qualified as "const" references to WasmModule outside of the decoder
and some test situations.

BUG=
==========

to

==========
[wasm] globals size is not a per-instance property.

Moved globals offsets calculation to the wasm module decoder, since
this is a property of the module, not of each instance.

Qualified as "const" references to WasmModule outside of the decoder
and some test situations.

BUG=

Committed: https://crrev.com/6b8d17e325ab611bbf3814a86610ad7af8d94512
Cr-Commit-Position: refs/heads/master@{#36484}
==========

[commit-bot: I haz the power, 2016-05-24 16:34:01]

Patchset 7 (id:??) landed as
https://crrev.com/6b8d17e325ab611bbf3814a86610ad7af8d94512
Cr-Commit-Position: refs/heads/master@{#36484}