Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2005933002: Rename IFX_Unknown to IFX_Retainable. (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Rename IFX_Unknown to IFX_Retainable. Rename addRef() method to Retain() to match Release(). This CL does not convert to CFX_RetainPtrs, which will happen in a follow-on. Committed: https://pdfium.googlesource.com/pdfium/+/a2d699f1462050833f959ebcf24853c2a6a10f72

Patch Set 1 #

Patch Set 2 : Typo in comment. #

Patch Set 3 : rebase #

Patch Set 4 : Consistent use of override #

Total comments: 1

Patch Set 5 : Alphabetical order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -40 lines) Patch
M core/fxcrt/include/fx_basic.h View 1 chunk +5 lines, -3 lines 0 comments Download
M core/fxcrt/include/fx_ucd.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fde/css/fde_css.h View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fde/css/fde_csscache.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fde/css/fde_cssstyleselector.h View 1 chunk +3 lines, -4 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.h View 1 2 3 1 chunk +12 lines, -8 lines 0 comments Download
M xfa/fde/css/fde_cssstylesheet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.h View 1 2 3 4 6 chunks +5 lines, -5 lines 0 comments Download
M xfa/fgas/layout/fgas_rtfbreak.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.h View 1 2 5 chunks +8 lines, -6 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Tom Sepez
Lei, for review.
4 years, 7 months ago (2016-05-23 17:58:37 UTC) #2
Lei Zhang
There's a couple red bots still.
4 years, 7 months ago (2016-05-23 18:28:28 UTC) #3
Tom Sepez
On 2016/05/23 18:28:28, Lei Zhang wrote: > There's a couple red bots still. Not anymore.
4 years, 7 months ago (2016-05-23 20:07:23 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2005933002/diff/60001/xfa/fgas/layout/fgas_rtfbreak.h File xfa/fgas/layout/fgas_rtfbreak.h (right): https://codereview.chromium.org/2005933002/diff/60001/xfa/fgas/layout/fgas_rtfbreak.h#newcode11 xfa/fgas/layout/fgas_rtfbreak.h:11: #include "core/fxcrt/include/fx_basic.h" alphabetical order
4 years, 7 months ago (2016-05-23 22:17:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005933002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005933002/80001
4 years, 7 months ago (2016-05-23 23:31:43 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 00:19:26 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/a2d699f1462050833f959ebcf24853c2a6a1...

Powered by Google App Engine
This is Rietveld 408576698