Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 2005853003: base: Add debugging to track down CreateFileMapping() errors. (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Add debugging to track down CreateFileMapping() errors. BUG=585013 Committed: https://crrev.com/9e1f3088559e8c51a6e109851df7a77f1acc76db Cr-Commit-Position: refs/heads/master@{#395639}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/memory/shared_memory_win.cc View 2 chunks +7 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005853003/1
4 years, 7 months ago (2016-05-23 22:44:50 UTC) #2
erikchen
thakis: Please review.
4 years, 7 months ago (2016-05-23 22:46:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 23:49:56 UTC) #6
Nico
lgtm, from the bug it sounds like this shouldn't be hit super frequently. https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_win.cc File ...
4 years, 7 months ago (2016-05-24 00:22:13 UTC) #7
erikchen
https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_win.cc File base/memory/shared_memory_win.cc (right): https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_win.cc#newcode116 base/memory/shared_memory_win.cc:116: base::debug::DumpWithoutCrashing(); This is perf-sensitive, but shouldn't be hit often. ...
4 years, 7 months ago (2016-05-24 00:41:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005853003/1
4 years, 7 months ago (2016-05-24 17:52:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 17:58:04 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9e1f3088559e8c51a6e109851df7a77f1acc76db Cr-Commit-Position: refs/heads/master@{#395639}
4 years, 7 months ago (2016-05-24 18:00:29 UTC) #13
erikchen
4 years, 7 months ago (2016-05-26 18:31:47 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2015983002/ by erikchen@chromium.org.

The reason for reverting is: No longer necessary:
https://bugs.chromium.org/p/chromium/issues/detail?id=585013.

Powered by Google App Engine
This is Rietveld 408576698