base: Add debugging to track down CreateFileMapping() errors.

base: Add debugging to track down CreateFileMapping() errors.

BUG=585013
Committed: https://crrev.com/9e1f3088559e8c51a6e109851df7a77f1acc76db
Cr-Commit-Position: refs/heads/master@{#395639}

[erikchen, 2016-05-23 22:43:58]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 22:44:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005853003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005853003/1

[erikchen, 2016-05-23 22:46:44]

erikchen@chromium.org changed reviewers:
+ thakis@chromium.org

[erikchen, 2016-05-23 22:46:45]

thakis: Please review.

[commit-bot: I haz the power, 2016-05-23 23:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 23:49:56]

Dry run: This issue passed the CQ dry run.

[Nico, 2016-05-24 00:22:13]

lgtm, from the bug it sounds like this shouldn't be hit super frequently.

https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_w...
File base/memory/shared_memory_win.cc (right):

https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_w...
base/memory/shared_memory_win.cc:116: base::debug::DumpWithoutCrashing();
is this code perf-sensitive? Should this just be full-on crash?

[erikchen, 2016-05-24 00:41:20]

https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_w...
File base/memory/shared_memory_win.cc (right):

https://codereview.chromium.org/2005853003/diff/1/base/memory/shared_memory_w...
base/memory/shared_memory_win.cc:116: base::debug::DumpWithoutCrashing();
This is perf-sensitive, but shouldn't be hit often. I don't want a full-on crash
because that would take down the browser process, whereas now the bug just takes
down the renderer process.

[erikchen, 2016-05-24 17:52:00]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-05-24 17:52:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005853003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005853003/1

[commit-bot: I haz the power, 2016-05-24 17:58:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-24 18:00:28]

Description was changed from

==========
base: Add debugging to track down CreateFileMapping() errors.

BUG=585013
==========

to

==========
base: Add debugging to track down CreateFileMapping() errors.

BUG=585013

Committed: https://crrev.com/9e1f3088559e8c51a6e109851df7a77f1acc76db
Cr-Commit-Position: refs/heads/master@{#395639}
==========

[commit-bot: I haz the power, 2016-05-24 18:00:29]

Patchset 1 (id:??) landed as
https://crrev.com/9e1f3088559e8c51a6e109851df7a77f1acc76db
Cr-Commit-Position: refs/heads/master@{#395639}

[erikchen, 2016-05-26 18:31:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2015983002/ by erikchen@chromium.org.

The reason for reverting is: No longer necessary:
https://bugs.chromium.org/p/chromium/issues/detail?id=585013.