Re-enable storage for Suborigins.

chrome/browser/browsing_data/cookies_tree_model_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/cookies_tree_model.h"
 
 #include <string>
 
 #include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 90 matching lines @@
     mock_browsing_data_quota_helper_ = nullptr;
     mock_browsing_data_file_system_helper_ = nullptr;
     mock_browsing_data_indexed_db_helper_ = nullptr;
     mock_browsing_data_appcache_helper_ = nullptr;
     mock_browsing_data_session_storage_helper_ = nullptr;
     mock_browsing_data_local_storage_helper_ = nullptr;
     mock_browsing_data_database_helper_ = nullptr;
     mock_browsing_data_flash_lso_helper_ = nullptr;
     base::MessageLoop::current()->RunUntilIdle();
   }
-
   std::unique_ptr<CookiesTreeModel> CreateCookiesTreeModelWithInitialSample() {
     LocalDataContainer* container =
         new LocalDataContainer(mock_browsing_data_cookie_helper_.get(),
                                mock_browsing_data_database_helper_.get(),
                                mock_browsing_data_local_storage_helper_.get(),
                                mock_browsing_data_session_storage_helper_.get(),
                                mock_browsing_data_appcache_helper_.get(),
                                mock_browsing_data_indexed_db_helper_.get(),
                                mock_browsing_data_file_system_helper_.get(),
                                mock_browsing_data_quota_helper_.get(),
@@ skipping 1525 matching lines @@
                              mock_browsing_data_cache_storage_helper_.get(),
                              mock_browsing_data_flash_lso_helper_.get());
   CookiesTreeModel cookies_model(container, special_storage_policy(), false);
 
   mock_browsing_data_cookie_helper_->
       AddCookieSamples(GURL(), "A=1");
   mock_browsing_data_cookie_helper_->Notify();
   EXPECT_EQ("A", GetDisplayedCookies(&cookies_model));
 }
 
+TEST_F(CookiesTreeModelTest, Suborigins) {
+  LocalDataContainer* container =
+      new LocalDataContainer(mock_browsing_data_cookie_helper_.get(),
+                             mock_browsing_data_database_helper_.get(),
+                             mock_browsing_data_local_storage_helper_.get(),
+                             mock_browsing_data_session_storage_helper_.get(),
+                             mock_browsing_data_appcache_helper_.get(),
+                             mock_browsing_data_indexed_db_helper_.get(),
+                             mock_browsing_data_file_system_helper_.get(),
+                             mock_browsing_data_quota_helper_.get(),
+                             mock_browsing_data_channel_id_helper_.get(),
+                             mock_browsing_data_service_worker_helper_.get(),
+                             mock_browsing_data_cache_storage_helper_.get(),
+                             mock_browsing_data_flash_lso_helper_.get());
+  CookiesTreeModel cookies_model(container, special_storage_policy(), false);
+
+  mock_browsing_data_local_storage_helper_
+      ->AddLocalStorageSamplesWithSuborigins();
+  mock_browsing_data_local_storage_helper_->Notify();
+  {
+    SCOPED_TRACE(
+        "Suborigins get their own storage partitions and are folded into their "
+        "respective hosts");
+    // root
+    // host4 -> local storage -> http://foobar_host4:4
+    //                        -> http://host4:4
+    // host3 -> local storage -> http://foobar_host3:3
+    // host2 -> local storage -> http://host2:2
+    // host1 -> local storage -> http://host1:1
+    EXPECT_EQ(14, cookies_model.GetRoot()->GetTotalNodeCount());
+    EXPECT_EQ(
+        "http://host1:1/,http://host2:2/,http://foobar_host3:3/,http://"

[msramek, 2016/05/25 16:09:29]

nit: line break after the last comma rather than the scheme separator?

[jww, 2016/05/25 20:46:22]

Done.

+        "foobar_host4:4/,http://host4:4/",
+        GetDisplayedLocalStorages(&cookies_model));
+    // Delete host4, which should delete foobar_host4:4 in addition to host4:4
+    DeleteStoredObjects(cookies_model.GetRoot()->GetChild(3));
+    EXPECT_EQ(10, cookies_model.GetRoot()->GetTotalNodeCount());
+  }
+}
+
 }  // namespace