Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2005763002:
Don't access context during OOM reporting if it's not available. (Closed)
|
Created:
4 years, 7 months ago by Igor Sheludko Modified:
4 years, 7 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionDon't access context during OOM reporting if it's not available.
BUG=chromium:612076
LOG=N
Committed: https://crrev.com/6b9c915794415dcd49d50eb82e532c52b42b3d60
Cr-Commit-Position: refs/heads/master@{#36459}
Patch Set 1 #Patch Set 2 : Fixed the problem the other way #Messages
Total messages: 21 (10 generated)
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005763002/1
ishell@chromium.org changed reviewers: + bmeurer@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [builtins] Use correct context in String.prototype.charCodeAt and String.prototype.charAt builtins when calling to runtime. Runtime::kFlattenString allocates and in case of OOM it requires non-null context to print a call stack. BUG=chromium:612076 LOG=N ========== to ========== [builtins] Use correct context in String.prototype.charCodeAt and String.prototype.charAt builtins when calling to runtime. Runtime::kFlattenString allocates and in case of OOM it requires non-null context to print a stack trace. BUG=chromium:612076 LOG=N ==========
Hm, this seems to fundamentally violate our assumption that heap allocation doesn't require a context. We should probably discuss this offline with the other folks first, and see if we can fix the OOM handler thing to not require a context.
Description was changed from ========== [builtins] Use correct context in String.prototype.charCodeAt and String.prototype.charAt builtins when calling to runtime. Runtime::kFlattenString allocates and in case of OOM it requires non-null context to print a stack trace. BUG=chromium:612076 LOG=N ========== to ========== Don't access context during OOM reporting if it's not available. BUG=chromium:612076 LOG=N ==========
I fixed the problem the other way. PTAL
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005763002/20001
Nice, thanks. LGTM.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005763002/20001
Message was sent while issue was closed.
Description was changed from ========== Don't access context during OOM reporting if it's not available. BUG=chromium:612076 LOG=N ========== to ========== Don't access context during OOM reporting if it's not available. BUG=chromium:612076 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Don't access context during OOM reporting if it's not available. BUG=chromium:612076 LOG=N ========== to ========== Don't access context during OOM reporting if it's not available. BUG=chromium:612076 LOG=N Committed: https://crrev.com/6b9c915794415dcd49d50eb82e532c52b42b3d60 Cr-Commit-Position: refs/heads/master@{#36459} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6b9c915794415dcd49d50eb82e532c52b42b3d60 Cr-Commit-Position: refs/heads/master@{#36459} |
