Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Unified Diff: media/capture/video/android/video_capture_device_android.h

Issue 2005753006: ImageCapture: ScopedResultCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: miu@s comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/android/video_capture_device_android.h
diff --git a/media/capture/video/android/video_capture_device_android.h b/media/capture/video/android/video_capture_device_android.h
index 529acd07d1e2605c1acf2b8a3212c29e207230d4..43cae00ea8905bb1cbcf959a86ba6e3468cc42a3 100644
--- a/media/capture/video/android/video_capture_device_android.h
+++ b/media/capture/video/android/video_capture_device_android.h
@@ -56,7 +56,7 @@ class MEDIA_EXPORT VideoCaptureDeviceAndroid : public VideoCaptureDevice {
void AllocateAndStart(const VideoCaptureParams& params,
std::unique_ptr<Client> client) override;
void StopAndDeAllocate() override;
- bool TakePhoto(const TakePhotoCallback& photo_callback) override;
+ void TakePhoto(ScopedCallback<TakePhotoCallback> callback) override;
// Implement org.chromium.media.VideoCapture.nativeOnFrameAvailable.
void OnFrameAvailable(JNIEnv* env,
@@ -99,7 +99,8 @@ class MEDIA_EXPORT VideoCaptureDeviceAndroid : public VideoCaptureDevice {
// List of |photo_callbacks_| in flight, being served in Java side.
base::Lock photo_callbacks_lock_;
- std::list<std::unique_ptr<TakePhotoCallback>> photo_callbacks_;
+ std::list<std::unique_ptr<ScopedCallback<TakePhotoCallback>>>
+ photo_callbacks_;
Name device_name_;
VideoCaptureFormat capture_format_;

Powered by Google App Engine
This is Rietveld 408576698