media/capture/video/fake_video_capture_device.h - Issue 2005753006: ImageCapture: ScopedResultCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/fake_video_capture_device.h

Issue 2005753006: ImageCapture: ScopedResultCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reillyg@ second round of comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/fake_video_capture_device.h

diff --git a/media/capture/video/fake_video_capture_device.h b/media/capture/video/fake_video_capture_device.h

index e7f7e795431b5fac8f58574f8af0f3978930a1c1..4536d9f79a23f7233a1ccf8a02caac9bbff68d66 100644

--- a/media/capture/video/fake_video_capture_device.h

+++ b/media/capture/video/fake_video_capture_device.h

@@ -37,7 +37,7 @@ class MEDIA_EXPORT FakeVideoCaptureDevice : public VideoCaptureDevice {

void AllocateAndStart(const VideoCaptureParams& params,

std::unique_ptr<Client> client) override;

void StopAndDeAllocate() override;

- bool TakePhoto(const TakePhotoCallback& photo_callback) override;

+ void TakePhoto(ScopedCallback<TakePhotoCallback> callback) override;

private:

void CaptureUsingOwnBuffers(base::TimeTicks expected_execution_time);