Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2005753003: [regexp] fix /ui regexp desugaring for text nodes. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] fix /ui regexp desugaring for text nodes. R=littledan@chromium.org BUG=v8:5036 Committed: https://crrev.com/5d93296a5c8cafd89e9b09d8c8c16ce764a92a80 Cr-Commit-Position: refs/heads/master@{#36453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/regexp/regexp-parser.cc View 1 chunk +4 lines, -8 lines 0 comments Download
A + test/mjsunit/regress/regress-5036.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
4 years, 7 months ago (2016-05-23 15:02:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005753003/1
4 years, 7 months ago (2016-05-23 15:02:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 15:33:36 UTC) #5
Dan Ehrenberg
lgtm
4 years, 7 months ago (2016-05-23 21:30:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005753003/1
4 years, 7 months ago (2016-05-23 22:18:19 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 22:20:09 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 22:23:54 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5d93296a5c8cafd89e9b09d8c8c16ce764a92a80
Cr-Commit-Position: refs/heads/master@{#36453}

Powered by Google App Engine
This is Rietveld 408576698