Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2005753002: firstPaintMetric: Report timeToOnload metric to check PCv1/v2 consistency (Closed)

Created:
4 years, 7 months ago by kouhei (in TOK)
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

firstPaintMetric: Report timeToOnload metric to check PCv1/v2 consistency This is a temporary metric used to confirm that PCv1 and PCv2 produce similar results. The metric will be reverted once the test is done. BUG=catapult:#2357 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/065d2bb2ba28ccf42ee52cbd22acc755bde22423

Patch Set 1 #

Total comments: 4

Patch Set 2 : ned's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -43 lines) Patch
M tracing/tracing/metrics/system_health/first_paint_metric.html View 1 5 chunks +60 lines, -43 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kouhei (in TOK)
PTAL
4 years, 7 months ago (2016-05-23 07:08:21 UTC) #3
nednguyen
lgtm https://codereview.chromium.org/2005753002/diff/1/tracing/tracing/metrics/system_health/first_paint_metric.html File tracing/tracing/metrics/system_health/first_paint_metric.html (right): https://codereview.chromium.org/2005753002/diff/1/tracing/tracing/metrics/system_health/first_paint_metric.html#newcode145 tracing/tracing/metrics/system_health/first_paint_metric.html:145: var TARGET_EVENTS = [ s/TARGET_EVENTS/METRICS https://codereview.chromium.org/2005753002/diff/1/tracing/tracing/metrics/system_health/first_paint_metric.html#newcode167 tracing/tracing/metrics/system_health/first_paint_metric.html:167: TARGET_EVENTS.forEach(function(def) ...
4 years, 7 months ago (2016-05-23 15:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005753002/20001
4 years, 7 months ago (2016-05-24 00:58:20 UTC) #7
kouhei (in TOK)
https://codereview.chromium.org/2005753002/diff/1/tracing/tracing/metrics/system_health/first_paint_metric.html File tracing/tracing/metrics/system_health/first_paint_metric.html (right): https://codereview.chromium.org/2005753002/diff/1/tracing/tracing/metrics/system_health/first_paint_metric.html#newcode145 tracing/tracing/metrics/system_health/first_paint_metric.html:145: var TARGET_EVENTS = [ On 2016/05/23 15:42:27, nednguyen wrote: ...
4 years, 7 months ago (2016-05-24 00:58:38 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 01:19:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698