Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2005723005: Reland of "[heap] Fine-grained JSArrayBuffer tracking" (Closed)

Created:
4 years, 7 months ago by Michael Lippautz
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of "[heap] Fine-grained JSArrayBuffer tracking" Track based on JSArrayBuffer addresses on pages instead of the attached backing store. Details of tracking: - Scavenge: New space pages are processes in bulk on the main thread - MC: Unswept pages are processed in bulk in parallel. All other pages are processed by the sweeper concurrently. This reverts commit d2dff0320b75bf6054e46c379b192619d4884caf. R=hpayer@chromium.org BUG=chromium:611688 LOG=N CQ_EXTRA_TRYBOTS=tryserver.v8:v8_linux_arm64_gc_stress_dbg,v8_linux_gc_stress_dbg,v8_mac_gc_stress_dbg,v8_linux64_tsan_rel,v8_mac64_asan_rel Committed: https://crrev.com/b5704bc1e6ba74c9ca975f5d58f5b2dc60261457 Cr-Commit-Position: refs/heads/master@{#36495}

Patch Set 1 : base #

Patch Set 2 : rebase after scavenger change on ToT #

Patch Set 3 : Lock-based implementation #

Patch Set 4 : Pipe through a single interface #

Patch Set 5 : Remove unnecessary sweeper api #

Total comments: 2

Patch Set 6 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+595 lines, -159 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/array-buffer-tracker.h View 1 2 3 1 chunk +89 lines, -35 lines 0 comments Download
M src/heap/array-buffer-tracker.cc View 1 2 3 2 chunks +132 lines, -86 lines 0 comments Download
A src/heap/array-buffer-tracker-inl.h View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 8 chunks +20 lines, -18 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/scavenger.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 6 chunks +27 lines, -1 line 0 comments Download
M src/heap/spaces.cc View 1 2 3 3 chunks +10 lines, -1 line 0 comments Download
M src/heap/spaces-inl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M test/cctest/heap/heap-utils.cc View 1 chunk +15 lines, -0 lines 0 comments Download
A test/cctest/heap/test-array-buffer-tracker.cc View 1 2 3 4 1 chunk +206 lines, -0 lines 0 comments Download

Messages

Total messages: 36 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005723005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005723005/120001
4 years, 7 months ago (2016-05-24 10:01:00 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/2126) v8_linux64_asan_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-24 10:29:45 UTC) #9
Michael Lippautz
PTAL
4 years, 7 months ago (2016-05-24 10:37:07 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005723005/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005723005/140001
4 years, 7 months ago (2016-05-24 10:37:21 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/6248) v8_linux_dbg_ng_triggered on ...
4 years, 7 months ago (2016-05-24 12:25:52 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005723005/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005723005/160001
4 years, 7 months ago (2016-05-24 13:27:58 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_rel/builds/14969) v8_linux_nodcheck_rel_ng on ...
4 years, 7 months ago (2016-05-24 13:33:00 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005723005/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005723005/180001
4 years, 7 months ago (2016-05-24 13:36:40 UTC) #23
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 14:18:07 UTC) #26
Hannes Payer (out of office)
lgtm https://codereview.chromium.org/2005723005/diff/200001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2005723005/diff/200001/src/heap/spaces.h#newcode472 src/heap/spaces.h:472: enum TrackerAccessMode { kDontCreate, kCreateIfNotPresent }; Can we ...
4 years, 7 months ago (2016-05-25 05:22:07 UTC) #27
Michael Lippautz
https://codereview.chromium.org/2005723005/diff/200001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/2005723005/diff/200001/src/heap/spaces.h#newcode472 src/heap/spaces.h:472: enum TrackerAccessMode { kDontCreate, kCreateIfNotPresent }; On 2016/05/25 05:22:07, ...
4 years, 7 months ago (2016-05-25 06:38:47 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005723005/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005723005/220001
4 years, 7 months ago (2016-05-25 06:39:40 UTC) #31
commit-bot: I haz the power
Committed patchset #6 (id:220001)
4 years, 7 months ago (2016-05-25 07:26:41 UTC) #33
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/b5704bc1e6ba74c9ca975f5d58f5b2dc60261457 Cr-Commit-Position: refs/heads/master@{#36495}
4 years, 7 months ago (2016-05-25 07:29:16 UTC) #35
Michael Lippautz
4 years, 7 months ago (2016-05-25 09:37:25 UTC) #36
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:220001) has been created in
https://codereview.chromium.org/2011863002/ by mlippautz@chromium.org.

The reason for reverting is: Breaking TSAN
 
https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20TSAN....

Powered by Google App Engine
This is Rietveld 408576698