Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 2005683002: Typed CSSOM: Rename SimpleLength to CSSSimpleLength (Closed)

Created:
4 years, 7 months ago by rjwright
Modified:
4 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Typed CSSOM: Rename SimpleLength to CSSSimpleLength This CL (along with https://codereview.chromium.org/1997503003/ and one future one) will replace https://codereview.chromium.org/1949343002/, which was very large and too hard to rebase after related file renames. Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159 BUG=610161 Committed: https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a Cr-Commit-Position: refs/heads/master@{#395794}

Patch Set 1 #

Patch Set 2 : fix SimpleLengthType compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -343 lines) Patch
M third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html View 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html View 1 chunk +133 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html View 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/typedcssom/simpleLength.html View 1 chunk +0 lines, -136 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h View 3 chunks +11 lines, -11 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
A + third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SimpleLength.h View 1 chunk +0 lines, -69 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SimpleLength.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/Source/core/css/cssom/SimpleLength.idl View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
rjwright
4 years, 7 months ago (2016-05-22 06:47:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005683002/1
4 years, 7 months ago (2016-05-22 06:48:21 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/70159)
4 years, 7 months ago (2016-05-22 06:59:32 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005683002/20001
4 years, 7 months ago (2016-05-23 01:55:27 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-23 04:08:27 UTC) #11
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-23 05:54:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005683002/20001
4 years, 7 months ago (2016-05-25 00:56:39 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 03:29:00 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 03:30:09 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a
Cr-Commit-Position: refs/heads/master@{#395794}

Powered by Google App Engine
This is Rietveld 408576698