Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2005653002: Distinguish between user and owner passwords. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Distinguish between user and owner passwords. BUG=pdfium:496 Committed: https://pdfium.googlesource.com/pdfium/+/27ddf161579f79510b361d0016ccc7f0cdffdc6d

Patch Set 1 #

Patch Set 2 : use CPDF_Document::GetUserPermissions() #

Patch Set 3 : fix bug #

Total comments: 4

Patch Set 4 : reference bug #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -32 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 1 2 3 4 1 chunk +10 lines, -3 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_parser_embeddertest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_security_handler.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_security_handler.cpp View 1 2 2 chunks +15 lines, -17 lines 0 comments Download
A core/fpdfapi/fpdf_parser/cpdf_security_handler_embeddertest.cpp View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_document.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_parser.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.h View 1 chunk +1 line, -0 lines 0 comments Download
M testing/embedder_test.cpp View 2 chunks +2 lines, -1 line 0 comments Download
A testing/resources/encrypted.pdf View Binary file 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-05-23 16:21:59 UTC) #2
Tom Sepez
https://codereview.chromium.org/2005653002/diff/40001/core/fpdfapi/fpdf_parser/cpdf_document.cpp File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right): https://codereview.chromium.org/2005653002/diff/40001/core/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode726 core/fpdfapi/fpdf_parser/cpdf_document.cpp:726: return 0xFFFFFFFF; This has always bothered me. I suspect ...
4 years, 7 months ago (2016-05-23 16:30:26 UTC) #3
Lei Zhang
https://codereview.chromium.org/2005653002/diff/40001/core/fpdfapi/fpdf_parser/cpdf_document.cpp File core/fpdfapi/fpdf_parser/cpdf_document.cpp (right): https://codereview.chromium.org/2005653002/diff/40001/core/fpdfapi/fpdf_parser/cpdf_document.cpp#newcode726 core/fpdfapi/fpdf_parser/cpdf_document.cpp:726: return 0xFFFFFFFF; On 2016/05/23 16:30:26, Tom Sepez wrote: > ...
4 years, 7 months ago (2016-05-23 18:41:24 UTC) #4
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-23 22:05:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005653002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005653002/80001
4 years, 7 months ago (2016-05-23 22:06:43 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 22:07:03 UTC) #9
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/27ddf161579f79510b361d0016ccc7f0cdff...

Powered by Google App Engine
This is Rietveld 408576698