Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2005523003:
Restore Force Mac Toolchain config. (Closed)
|
Created:
4 years, 7 months ago by justincohen Modified:
4 years, 7 months ago CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master Target Ref:
refs/heads/master Project:
build Visibility:
Public. |
DescriptionRestore Force Mac Toolchain config.
BUG=601506
Committed: https://chromium.googlesource.com/chromium/tools/build/+/772692cbb72e1195ed8d3386c098281ef480d6f5
Patch Set 1 #Patch Set 2 : Missing #
Messages
Total messages: 25 (11 generated)
justincohen@chromium.org changed reviewers: + dba@chromium.org, smut@chromium.org
ptal
lgtm
The CQ bit was checked by justincohen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dba@chromium.org Link to the patchset: https://codereview.chromium.org/2005523003/#ps20001 (title: "Missing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005523003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
justincohen@chromium.org changed reviewers: + smut@google.com
The CQ bit was checked by smut@google.com
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005523003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build Presubmit on tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)
justincohen@chromium.org changed reviewers: + dpranke@google.com, phajdan.jr@chromium.org
PTAL.
On 2016/05/24 21:29:55, justincohen wrote: > PTAL. This is probably because smut1 needs to say the magic letters, not smut without 1.
On 2016/05/24 21:31:07, dba (chromium) wrote: > On 2016/05/24 21:29:55, justincohen wrote: > > PTAL. > > This is probably because smut1 needs to say the magic letters, not smut without > 1. No it's that chromium_tests/OWNERS has "set noparent" so smut@google.com's ownership is invalidated. Note that between the first and second presubmit runs, smut's (not smut1's) approval was enough to make the warning go away for the .json, just not the .py.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
lgtm
The CQ bit was checked by justincohen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005523003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005523003/20001
Message was sent while issue was closed.
Description was changed from ========== Restore Force Mac Toolchain config. BUG=601506 ========== to ========== Restore Force Mac Toolchain config. BUG=601506 Committed: https://chromium.googlesource.com/chromium/tools/build/+/772692cbb72e1195ed8d... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/build/+/772692cbb72e1195ed8d... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
