components/metrics/metrics_log.cc - Issue 2005513002: Fix for setting the os listed in metrics reporting for Blimp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_log.cc

Issue 2005513002: Fix for setting the os listed in metrics reporting for Blimp. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase to resolve patch failure. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_log.cc

diff --git a/components/metrics/metrics_log.cc b/components/metrics/metrics_log.cc

index 75ed54deb7158ad8d1086149526b9a7385afa703..d435b0ea7814d2fb4c6d25432b6d2dbdf7e69ea3 100644

--- a/components/metrics/metrics_log.cc

+++ b/components/metrics/metrics_log.cc

@@ -351,10 +351,10 @@ void MetricsLog::RecordEnvironment(

hardware->set_dll_base(reinterpret_cast<uint64_t>(CURRENT_MODULE()));

#endif

+ SystemProfileProto::OS* os = system_profile->mutable_os();

#if defined(OVERRIDE_OS_NAME_TO_BLIMP)

os->set_name("Blimp");

#else

- SystemProfileProto::OS* os = system_profile->mutable_os();

std::string os_name = base::SysInfo::OperatingSystemName();

os->set_name(os_name);

#endif

« no previous file with comments | « components/metrics/BUILD.gn ('k') | no next file » | no next file with comments »