Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2005513002: Fix for setting the os listed in metrics reporting for Blimp. (Closed)

Created:
4 years, 7 months ago by Jess
Modified:
4 years, 7 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for setting the os listed in metrics reporting for Blimp. Metrics uploads from blimp engine are including OS = Linux in the System Proto instead of the desired "Blimp". This is because the defines isn't getting set in BUILD.gn until after metrics_log.cc is built. This change will ensure the blimp engine is uploading logs with the desired system information so they can be separate from other linux metrics logs. BUG=613680 Committed: https://crrev.com/d599415d4e9fbb458090f9cd544a17dcd0a90a6c Cr-Commit-Position: refs/heads/master@{#395170}

Patch Set 1 #

Patch Set 2 : Rebase to resolve patch failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M components/metrics/BUILD.gn View 1 2 chunks +6 lines, -6 lines 0 comments Download
M components/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
Jess
Short change to fix a BUILD file error that is a root cause of Blimp ...
4 years, 7 months ago (2016-05-20 20:04:56 UTC) #2
Jess
Short change to fix a BUILD file error that is a root cause of Blimp ...
4 years, 7 months ago (2016-05-20 20:04:58 UTC) #3
Alexei Svitkine (slow)
I think you need to sync your client as bots show patch failure.
4 years, 7 months ago (2016-05-20 20:06:12 UTC) #4
Jess
On 2016/05/20 20:06:12, Alexei Svitkine (OOO til Tues) wrote: > I think you need to ...
4 years, 7 months ago (2016-05-20 20:13:21 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 7 months ago (2016-05-20 20:15:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005513002/20001
4 years, 7 months ago (2016-05-20 21:02:33 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 21:27:42 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 21:28:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d599415d4e9fbb458090f9cd544a17dcd0a90a6c
Cr-Commit-Position: refs/heads/master@{#395170}

Powered by Google App Engine
This is Rietveld 408576698