Added check to debug object migration crashes.

Added check to debug object migration crashes.

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15849

[Michael Starzinger, 2013-07-23 21:10:47]

https://codereview.chromium.org/20055002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/20055002/diff/1/src/mark-compact.cc#newcode2738
src/mark-compact.cc:2738: CHECK(heap_->TargetSpace(HeapObject::FromAddress(src))
==
Please add a TODO here that this should be turned into an ASSERT soon. We only
want this for one or two Canary builds.

Also this ASSERT has nothing to do with this particular location. It has to hold
at method entry after the destination space has been checked (e.g. at line
2728). Please move it up, out of the loop.

[Hannes Payer (out of office), 2013-07-24 09:04:12]

https://codereview.chromium.org/20055002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/20055002/diff/1/src/mark-compact.cc#newcode2738
src/mark-compact.cc:2738: CHECK(heap_->TargetSpace(HeapObject::FromAddress(src))
==
On 2013/07/23 21:10:47, Michael Starzinger wrote:
> Please add a TODO here that this should be turned into an ASSERT soon. We only
> want this for one or two Canary builds.
> 
> Also this ASSERT has nothing to do with this particular location. It has to
hold
> at method entry after the destination space has been checked (e.g. at line
> 2728). Please move it up, out of the loop.

Done.

[Michael Starzinger, 2013-07-24 09:19:04]

LGTM.

[Hannes Payer (out of office), 2013-07-24 09:20:01]

Committed patchset #4 manually as r15849 (presubmit successful).