Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2005493002: S390: Added remaining generated instructions to S390 simulator EVALUATE code. (Closed)

Created:
4 years, 7 months ago by bcleung
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Added remaining generated instructions to S390 simulator EVALUATE code. All EVALUATE functions for unimplemented instructions will now throw an UNIMPLEMENTED error if called. R=joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Committed: https://crrev.com/9159684edafd61f43407f021626928f05b579a9b Cr-Commit-Position: refs/heads/master@{#36488}

Patch Set 1 #

Patch Set 2 : Removed DecodeInstructionOriginal from unimplemented instructions; they will now return 0. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2654 lines, -476 lines) Patch
M src/s390/simulator-s390.cc View 1 77 chunks +2654 lines, -476 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
john.yan
lgtm lgtm
4 years, 7 months ago (2016-05-24 17:24:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005493002/20001
4 years, 7 months ago (2016-05-24 18:06:03 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 18:35:26 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 18:39:31 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/9159684edafd61f43407f021626928f05b579a9b
Cr-Commit-Position: refs/heads/master@{#36488}

Powered by Google App Engine
This is Rietveld 408576698