chrome/browser/extensions/bluetooth_chrome_extension_chooser_dialog.h - Issue 2005443002: Implement bluetooth chooser for Chrome Apps on Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/bluetooth_chrome_extension_chooser_dialog.h

Issue 2005443002: Implement bluetooth chooser for Chrome Apps on Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactor_chooser_bubble_ui_cocoa

Patch Set: rebase and display app name on the chooser title Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_BLUETOOTH_CHROME_EXTENSION_CHOOSER_DIALOG_H_

	6 #define CHROME_BROWSER_EXTENSIONS_BLUETOOTH_CHROME_EXTENSION_CHOOSER_DIALOG_H_

	7

	8 #include "base/macros.h"

	9

	10 #include "chrome/browser/extensions/chrome_extension_chooser_dialog.h"

	11

	12 // Bluetooth implementation of ChromeExtensionChooserDialog.

	13 class BluetoothChromeExtensionChooserDialog

	14 : public ChromeExtensionChooserDialog {

	15 public:

	16 explicit BluetoothChromeExtensionChooserDialog(

	17 content::WebContents* web_contents);

	18 ~BluetoothChromeExtensionChooserDialog() override;

	19

	20 GURL GetHelpCenterUrl() const override;
	Reilly Grant (use Gerrit) 2016/05/23 19:36:49 Can you move this virtual function to ChooserContr Can you move this virtual function to ChooserController so that it can be implemented by BluetoothChooserController? That would remove the need for both a BluetoothChromeExtensionChooserDialog and UsbChromeExtensionChooserDialog. juncai 2016/05/27 21:30:36 Done. Show quoted text On 2016/05/23 19:36:49, Reilly Grant wrote: > Can you move this virtual function to ChooserController so that it can be > implemented by BluetoothChooserController? That would remove the need for both a > BluetoothChromeExtensionChooserDialog and UsbChromeExtensionChooserDialog. Done.
	21

	22 DISALLOW_COPY_AND_ASSIGN(BluetoothChromeExtensionChooserDialog);

	23 };

	24

	25 #endif // CHROME_BROWSER_EXTENSIONS_BLUETOOTH_CHROME_EXTENSION_CHOOSER_DIALOG_H _

OLD	NEW