Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install
Patch Set: Fix multiple definition of signature; addressing nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
diff --git a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
index 0a236a0b18bcaac1852bb4d893e34ea72c429c25..a5a268fbb0a580c98c9b4c95175823c4970ca3d3 100644
--- a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
+++ b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
@@ -4,7 +4,14 @@
#include "core/origin_trials/OriginTrialContext.h"
+#include "bindings/core/v8/ScriptController.h"
+#include "bindings/core/v8/V8Binding.h"
+#include "bindings/core/v8/WindowProxy.h"
+#include "bindings/core/v8/WorkerOrWorkletScriptController.h"
+#include "core/dom/Document.h"
#include "core/dom/ExecutionContext.h"
+#include "core/frame/LocalFrame.h"
+#include "core/workers/WorkerGlobalScope.h"
#include "platform/Histogram.h"
#include "platform/RuntimeEnabledFeatures.h"
#include "platform/weborigin/SecurityOrigin.h"
@@ -14,6 +21,8 @@
#include "public/platform/WebTrialTokenValidator.h"
#include "wtf/text/StringBuilder.h"
+#include <v8.h>
+
namespace blink {
namespace {
@@ -234,11 +243,42 @@ void OriginTrialContext::addToken(const String& token)
{
if (!token.isEmpty())
m_tokens.append(token);
+ initializePendingFeatures();
}
void OriginTrialContext::addTokens(const Vector<String>& tokens)
{
m_tokens.appendVector(tokens);
+ initializePendingFeatures();
+}
+
+void OriginTrialContext::initializePendingFeatures()
+{
+ // TODO(iclelland): Factor this logic out to methods on the various
+ // execution contexts
+ if (m_host->isDocument()) {
+ LocalFrame* frame = toDocument(m_host.get())->frame();
+ if (!frame)
+ return;
+ ScriptState* state = ScriptState::forMainWorld(frame);
+ if (!state)
+ return;
+ if (!frame->script().windowProxy(state->world())->isContextInitialized())
+ return;
+ v8::HandleScope handleScope(state->isolate());
+ installOriginTrials(state);
+ } else if (m_host->isWorkerGlobalScope()) {
+ WorkerOrWorkletScriptController* scriptController = toWorkerGlobalScope(m_host.get())->scriptController();
+ if (!scriptController)
+ return;
+ ScriptState* state = scriptController->getScriptState();
+ if (!state)
+ return;
+ if (!scriptController->isContextInitialized())
+ return;
+ v8::HandleScope handleScope(state->isolate());
+ installOriginTrials(state);
+ }
}
void OriginTrialContext::setFeatureBindingsInstalled(const String& featureName)

Powered by Google App Engine
This is Rietveld 408576698