third_party/WebKit/Source/bindings/scripts/v8_utilities.py - Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install

Patch Set: Fix multiple definition of signature; addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_attributes.py ('k') | third_party/WebKit/Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_utilities.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

index 4691f57ec122126f6e03d94644c703113bfdd20d..e934c986ad2ad5f3dc454be4b2e97b8469a1cd61 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_utilities.py

@@ -393,7 +393,7 @@ def origin_trial_enabled_function_name(definition_or_member):

'%s.%s' % (definition_or_member.idl_name, definition_or_member.name))

if is_origin_trial_enabled:

- includes.add('core/inspector/ConsoleMessage.h')

+ includes.add('bindings/core/v8/ScriptState.h')

includes.add('core/origin_trials/OriginTrials.h')

trial_name = extended_attributes['OriginTrialEnabled']

@@ -402,6 +402,13 @@ def origin_trial_enabled_function_name(definition_or_member):

return None

+def origin_trial_feature_name(definition_or_member):

+ extended_attributes = definition_or_member.extended_attributes

+ if 'OriginTrialEnabled' not in extended_attributes:

+ return None

+ return extended_attributes['OriginTrialEnabled']

def runtime_feature_name(definition_or_member):

extended_attributes = definition_or_member.extended_attributes

if 'RuntimeEnabled' not in extended_attributes: