Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install
Patch Set: Addressing review comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
diff --git a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
index 8499a3fb90eacbf98302a97c1f3b1423dc2b3f24..16ba61e76ccfcd5b6c6e5cfafa01b79fb1054ded 100644
--- a/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
+++ b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
@@ -70,6 +70,13 @@ public:
// to provide a message for features that are not enabled.
bool isFeatureEnabled(const String& featureName, String* errorMessage);
+ // Installs JavaScript bindings for any features which should be enabled by
+ // the current set of trial tokens. This method is idempotent; only features
+ // which have been enabled since the last time it was run will be installed.
+ // If the V8 context for the host execution context has not been
+ // initialized, then this method will return without doing anything.
+ void initializePendingTrials();
chasej 2016/05/31 15:42:13 Nit: maybe this should be named "initializePending
iclelland 2016/05/31 16:03:44 Done.
+
void setFeatureBindingsInstalled(const String& featureName);
bool featureBindingsInstalled(const String& featureName);

Powered by Google App Engine
This is Rietveld 408576698