third_party/WebKit/Source/bindings/templates/attributes.cpp - Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install

Patch Set: Fix comments, Re-apply v8 enumerable/configurable/rw attributes to descriptor Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp ('K') | « third_party/WebKit/Source/bindings/scripts/v8_utilities.py ('k') | third_party/WebKit/Source/bindings/templates/constants.cpp » ('j') | third_party/WebKit/Source/bindings/templates/interface_base.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/attributes.cpp

diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp b/third_party/WebKit/Source/bindings/templates/attributes.cpp

index e253d3276a0c63195123c774152b14157c3b361f..2b8309463d90c8acc706d7736d6cd2a5e6b44e99 100644

--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp

+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp

@@ -1,4 +1,4 @@

-{% from 'utilities.cpp' import declare_enum_validation_variable, v8_value_to_local_cpp_value, check_origin_trial %}

+{% from 'utilities.cpp' import declare_enum_validation_variable, v8_value_to_local_cpp_value %}

{##############################################################################}

{% macro attribute_getter(attribute, world_suffix) %}

@@ -9,9 +9,6 @@ const v8::PropertyCallbackInfo<v8::Value>& info

const v8::FunctionCallbackInfo<v8::Value>& info

{%- endif %})

{

- {% if attribute.origin_trial_enabled_function %}

- {{check_origin_trial(attribute) | indent}}

- {% endif %}

{% if attribute.is_reflect and not attribute.is_url

and attribute.idl_type == 'DOMString' and is_node

and not attribute.is_implemented_in_private_script %}

@@ -189,9 +186,6 @@ const v8::FunctionCallbackInfo<v8::Value>& info

{% if attribute.measure_as %}

UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{attribute.measure_as('AttributeGetter')}});

{% endif %}

- {% if attribute.origin_trial_enabled_function %}

- {{check_origin_trial(attribute) | indent}}

- {% endif %}

{% if world_suffix in attribute.activity_logging_world_list_for_getter %}

ScriptState* scriptState = ScriptState::from(info.GetIsolate()->GetCurrentContext());

V8PerContextData* contextData = scriptState->perContextData();

@@ -221,9 +215,6 @@ static void {{attribute.name}}ConstructorGetterCallback{{world_suffix}}(v8::Loca

{% if attribute.measure_as %}

UseCounter::countIfNotPrivateScript(info.GetIsolate(), currentExecutionContext(info.GetIsolate()), UseCounter::{{attribute.measure_as('ConstructorGetter')}});

{% endif %}

- {% if attribute.origin_trial_enabled_function %}

- {{check_origin_trial(attribute) | indent}}

- {% endif %}

v8ConstructorAttributeGetter(property, info);

}

{% endmacro %}

@@ -423,9 +414,6 @@ bool {{v8_class}}::PrivateScript::{{attribute.name}}AttributeGetter(LocalFrame*

if (holder.IsEmpty())

return false;

- {% if attribute.origin_trial_enabled_function %}

- {{check_origin_trial(attribute, "scriptState->isolate()") | indent}}

- {% endif %}

ExceptionState exceptionState(ExceptionState::GetterContext, "{{attribute.name}}", "{{cpp_class}}", scriptState->context()->Global(), scriptState->isolate());

v8::Local<v8::Value> v8Value = PrivateScriptRunner::runDOMAttributeGetter(scriptState, scriptStateInUserScript, "{{cpp_class}}", "{{attribute.name}}", holder);