Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Issue 2005433002: [Origin Trials] Install origin trial bindings on V8 context conditionally (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@track-ef-install
Patch Set: Clean up Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
index 44f8a1e7a85e2a92ee440459aa221eefaba9befa..dbaef4d0324e7214a22c640f2a8bc1277a07c65c 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
@@ -818,6 +818,33 @@ v8::Local<v8::Context> toV8ContextEvenIfDetached(Frame* frame, DOMWrapperWorld&
return frame->windowProxy(world)->contextIfInitialized();
}
+void initializeOriginTrialsCore(v8::Local<v8::Context> context, const DOMWrapperWorld& world)
haraken 2016/05/27 00:01:42 Who calls this method? I guess initializeOriginTri
iclelland 2016/05/27 03:19:43 Yes, when registerInitializeOriginTrialsForModules
+{
+ // TODO(iclelland): Generate all of this logic at compile-time, based on the
+ // configuration of origin trial enabled attibutes and interfaces in IDL
+ // files. (crbug.com/615060)
+
+ DCHECK(!context.IsEmpty());
+ // Initialization code for origin trials for core bindings, if necessary,
+ // should go here.
+}
+
+namespace {
+initializeOriginTrialsFunction s_initializeOriginTrialsFunction = &initializeOriginTrialsCore;
+}
+
+void initializeOriginTrials(v8::Local<v8::Context> context, const DOMWrapperWorld& world)
+{
+ (*s_initializeOriginTrialsFunction)(context, world);
+}
+
+initializeOriginTrialsFunction setInitializeOriginTrialsFunction(initializeOriginTrialsFunction newInitializeOriginTrialsFunction)
+{
+ initializeOriginTrialsFunction originalFunction = s_initializeOriginTrialsFunction;
+ s_initializeOriginTrialsFunction = newInitializeOriginTrialsFunction;
+ return originalFunction;
+}
+
void crashIfIsolateIsDead(v8::Isolate* isolate)
{
if (isolate->IsDead()) {

Powered by Google App Engine
This is Rietveld 408576698