[Origin Trials] Install origin trial bindings on V8 context conditionally

third_party/WebKit/Source/bindings/modules/v8/V8BindingForModules.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 18 matching lines @@
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "bindings/core/v8/V8ArrayBuffer.h"
 #include "bindings/core/v8/V8ArrayBufferView.h"
 #include "bindings/core/v8/V8Binding.h"
 #include "bindings/core/v8/V8Blob.h"
 #include "bindings/core/v8/V8DOMStringList.h"
 #include "bindings/core/v8/V8File.h"
 #include "bindings/core/v8/V8Uint8Array.h"
 #include "bindings/core/v8/WorkerOrWorkletScriptController.h"
 #include "bindings/modules/v8/ToV8ForModules.h"
+#include "bindings/modules/v8/V8DedicatedWorkerGlobalScopePartial.h"
 #include "bindings/modules/v8/V8IDBCursor.h"
 #include "bindings/modules/v8/V8IDBCursorWithValue.h"
 #include "bindings/modules/v8/V8IDBDatabase.h"
 #include "bindings/modules/v8/V8IDBIndex.h"
 #include "bindings/modules/v8/V8IDBKeyRange.h"
 #include "bindings/modules/v8/V8IDBObjectStore.h"
+#include "bindings/modules/v8/V8NavigatorPartial.h"
+#include "bindings/modules/v8/V8ServiceWorkerGlobalScope.h"
+#include "bindings/modules/v8/V8SharedWorkerGlobalScopePartial.h"
+#include "bindings/modules/v8/V8WindowPartial.h"
 #include "bindings/modules/v8/V8WorkletGlobalScope.h"
 #include "core/dom/DOMArrayBuffer.h"
 #include "core/dom/DOMArrayBufferView.h"
 #include "core/dom/ExecutionContext.h"
+#include "core/origin_trials/OriginTrialContext.h"
 #include "modules/indexeddb/IDBKey.h"
 #include "modules/indexeddb/IDBKeyPath.h"
 #include "modules/indexeddb/IDBKeyRange.h"
 #include "modules/indexeddb/IDBTracing.h"
 #include "modules/indexeddb/IDBValue.h"
 #include "modules/worklet/WorkletGlobalScope.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/SharedBuffer.h"
 #include "wtf/MathExtras.h"
 #include "wtf/Vector.h"
@@ skipping 466 matching lines @@
     if (context.IsEmpty())
         return nullptr;
     v8::Local<v8::Object> global = context->Global();
     v8::Local<v8::Object> workletWrapper = V8WorkletGlobalScope::findInstanceInPrototypeChain(global, context->GetIsolate());
     if (!workletWrapper.IsEmpty())
         return V8WorkletGlobalScope::toImpl(workletWrapper);
     // FIXME: Is this line of code reachable?
     return nullptr;
 }
 
+namespace {
+initializeOriginTrialsFunction s_originalInitializeOriginTrialsFunction = nullptr;
+}
+
+void initializeOriginTrialsForModules(v8::Local<v8::Context> context, const DOMWrapperWorld& world)
+{
+    DCHECK(!context.IsEmpty());
+    (*s_originalInitializeOriginTrialsFunction)(context, world);
+    context->Enter();
+
+    ExecutionContext* executionContext = toExecutionContext(context);
+    OriginTrialContext* originTrialContext = OriginTrialContext::from(executionContext, OriginTrialContext::DontCreateIfNotExists);
+    if (!originTrialContext)
+        return;
+
+    v8::Local<v8::Object> global = context->Global();
+    v8::Isolate* isolate = context->GetIsolate();
+    v8::Local<v8::Function> interface = v8::Function::New(context, nullptr).ToLocalChecked();
+
+    if (originTrialContext->isFeatureEnabled("DurableStorage", nullptr) && !originTrialContext->featureBindingsInstalled("DurableStorage")) {

[chasej, 2016/05/20 20:18:14]

Add a comment/TODO that this will eventually be generated code?

[chasej, 2016/05/20 20:18:14]

Should this check if the bindings have been installed first? I would think that
check is cheap, and certainly faster than the isFeatureEnabled() check.  That
would be an optimization for the {enabled, already installed} scenario, but I
don't know how often that would occur (if ever). For the {not enabled, *}
scenarios it does mean it would always do the installed check, which the current
implementation avoids.

[iclelland, 2016/05/26 17:09:21]

Done.

[iclelland, 2016/05/26 17:09:21]

Done. Also in WebCoreTestSupport.cpp

+        if (executionContext->isDocument()) {
+            v8::Local<v8::String> navigatorName = v8::String::NewFromUtf8(isolate, "navigator", v8::NewStringType::kNormal).ToLocalChecked();
+            v8::Local<v8::Object> navigator = global->Get(context, navigatorName).ToLocalChecked()->ToObject();
+            V8WindowPartial::installDurableStorage(isolate, world, global, interface);
+            V8NavigatorPartial::installDurableStorage(isolate, world, navigator, interface);
+        } else if (executionContext->isSharedWorkerGlobalScope()) {
+            V8SharedWorkerGlobalScopePartial::installDurableStorage(isolate, world, global, interface);
+        } else if (executionContext->isDedicatedWorkerGlobalScope()) {
+            V8DedicatedWorkerGlobalScopePartial::installDurableStorage(isolate, world, global, interface);
+        } else if (executionContext->isServiceWorkerGlobalScope()) {
+            V8ServiceWorkerGlobalScope::installDurableStorage(isolate, world, global, interface);
+        }
+        originTrialContext->setFeatureBindingsInstalled("DurableStorage");
+    }
+    context->Exit();
+}
+
+void registerInitializeOriginTrialsForModules()
+{
+    s_originalInitializeOriginTrialsFunction = setInitializeOriginTrialsFunction(&initializeOriginTrialsForModules);
+}
 } // namespace blink