Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 200543005: ConvolverNode.buffer sample rate must match AudioContext rate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update expected results. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/webaudio/dom-exceptions.html
diff --git a/LayoutTests/webaudio/dom-exceptions.html b/LayoutTests/webaudio/dom-exceptions.html
index 8cd26a476fd158954c7f53788ca51e0d404017e2..d18575f6123821fb7769a86a1f1832e1a0782b65 100644
--- a/LayoutTests/webaudio/dom-exceptions.html
+++ b/LayoutTests/webaudio/dom-exceptions.html
@@ -165,6 +165,13 @@ function runTest() {
node.connect(context.destination);
shouldThrow("node.gain.exponentialRampToValueAtTime(-1, 0.1)");
shouldThrow("node.gain.exponentialRampToValueAtTime(0, 0.1)");
+
+ // Convolver buffer rate must match context rate. Create on offline context so we
+ // specify the context rate exactly, in case the test is run on platforms with different
+ // HW sample rates.
+ shouldNotThrow("oc = new webkitOfflineAudioContext(1, 44100, 44100)");
+ shouldNotThrow("conv = oc.createConvolver()");
+ shouldThrow("conv.buffer = oc.createBuffer(1, 100, 22050)");
}
runTest();
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | Source/modules/webaudio/ConvolverNode.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698