Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: LayoutTests/webaudio/dom-exceptions.html

Issue 200543005: ConvolverNode.buffer sample rate must match AudioContext rate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webaudio/dom-exceptions.html
diff --git a/LayoutTests/webaudio/dom-exceptions.html b/LayoutTests/webaudio/dom-exceptions.html
index 8cd26a476fd158954c7f53788ca51e0d404017e2..187b5b70f8491601e4ba75f2cd1c892a39b18c70 100644
--- a/LayoutTests/webaudio/dom-exceptions.html
+++ b/LayoutTests/webaudio/dom-exceptions.html
@@ -165,6 +165,13 @@ function runTest() {
node.connect(context.destination);
shouldThrow("node.gain.exponentialRampToValueAtTime(-1, 0.1)");
shouldThrow("node.gain.exponentialRampToValueAtTime(0, 0.1)");
+
+ // Convolver buffer rate must match context rate. Create on offline context so we
+ // specify the context rate exactly, in case the test is run on platforms with different
+ // HW sample rates.
+ shouldNotThrow("oc = new webkitOfflineAudioContext(1, 44100, 44100)");
+ conv = oc.createConvolver();
Ken Russell (switch to Gerrit) 2014/03/17 18:21:38 Maybe this should be wrapped in a shouldNotThrow t
Raymond Toy 2014/03/17 19:42:13 Done. Do you think this should be done in general
Ken Russell (switch to Gerrit) 2014/03/17 21:35:30 If you think it will improve clarity of the test,
+ shouldThrow("conv.buffer = oc.createBuffer(1, 100, 22050)");
}
runTest();
« no previous file with comments | « no previous file | LayoutTests/webaudio/dom-exceptions-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698