Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: Source/modules/webaudio/ConvolverNode.h

Issue 200543005: ConvolverNode.buffer sample rate must match AudioContext rate (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update expected results. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010, Google Inc. All rights reserved. 2 * Copyright (C) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 15 matching lines...) Expand all
26 #define ConvolverNode_h 26 #define ConvolverNode_h
27 27
28 #include "modules/webaudio/AudioNode.h" 28 #include "modules/webaudio/AudioNode.h"
29 #include "wtf/OwnPtr.h" 29 #include "wtf/OwnPtr.h"
30 #include "wtf/RefPtr.h" 30 #include "wtf/RefPtr.h"
31 #include "wtf/ThreadingPrimitives.h" 31 #include "wtf/ThreadingPrimitives.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 class AudioBuffer; 35 class AudioBuffer;
36 class ExceptionState;
36 class Reverb; 37 class Reverb;
37 38
38 class ConvolverNode FINAL : public AudioNode { 39 class ConvolverNode FINAL : public AudioNode {
39 public: 40 public:
40 static PassRefPtr<ConvolverNode> create(AudioContext* context, float sampleR ate) 41 static PassRefPtr<ConvolverNode> create(AudioContext* context, float sampleR ate)
41 { 42 {
42 return adoptRef(new ConvolverNode(context, sampleRate)); 43 return adoptRef(new ConvolverNode(context, sampleRate));
43 } 44 }
44 45
45 virtual ~ConvolverNode(); 46 virtual ~ConvolverNode();
46 47
47 // AudioNode 48 // AudioNode
48 virtual void process(size_t framesToProcess) OVERRIDE; 49 virtual void process(size_t framesToProcess) OVERRIDE;
49 virtual void initialize() OVERRIDE; 50 virtual void initialize() OVERRIDE;
50 virtual void uninitialize() OVERRIDE; 51 virtual void uninitialize() OVERRIDE;
51 52
52 // Impulse responses 53 // Impulse responses
53 void setBuffer(AudioBuffer*); 54 void setBuffer(AudioBuffer*, ExceptionState&);
54 AudioBuffer* buffer(); 55 AudioBuffer* buffer();
55 56
56 bool normalize() const { return m_normalize; } 57 bool normalize() const { return m_normalize; }
57 void setNormalize(bool normalize) { m_normalize = normalize; } 58 void setNormalize(bool normalize) { m_normalize = normalize; }
58 59
59 private: 60 private:
60 ConvolverNode(AudioContext*, float sampleRate); 61 ConvolverNode(AudioContext*, float sampleRate);
61 62
62 virtual double tailTime() const OVERRIDE; 63 virtual double tailTime() const OVERRIDE;
63 virtual double latencyTime() const OVERRIDE; 64 virtual double latencyTime() const OVERRIDE;
64 65
65 OwnPtr<Reverb> m_reverb; 66 OwnPtr<Reverb> m_reverb;
66 RefPtr<AudioBuffer> m_buffer; 67 RefPtr<AudioBuffer> m_buffer;
67 68
68 // This synchronizes dynamic changes to the convolution impulse response wit h process(). 69 // This synchronizes dynamic changes to the convolution impulse response wit h process().
69 mutable Mutex m_processLock; 70 mutable Mutex m_processLock;
70 71
71 // Normalize the impulse response or not. Must default to true. 72 // Normalize the impulse response or not. Must default to true.
72 bool m_normalize; 73 bool m_normalize;
73 }; 74 };
74 75
75 } // namespace WebCore 76 } // namespace WebCore
76 77
77 #endif // ConvolverNode_h 78 #endif // ConvolverNode_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698