ConvolverNode.buffer sample rate must match AudioContext rate

Source/modules/webaudio/ConvolverNode.cpp

 /*
  * Copyright (C) 2010, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 10 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 
 #if ENABLE(WEB_AUDIO)
 
 #include "modules/webaudio/ConvolverNode.h"
 
+#include "bindings/v8/ExceptionState.h"
+#include "core/dom/ExceptionCode.h"
 #include "platform/audio/Reverb.h"
 #include "modules/webaudio/AudioBuffer.h"
 #include "modules/webaudio/AudioContext.h"
 #include "modules/webaudio/AudioNodeInput.h"
 #include "modules/webaudio/AudioNodeOutput.h"
 #include "wtf/MainThread.h"
 
 // Note about empirical tuning:
 // The maximum FFT size affects reverb performance and accuracy.
 // If the reverb is single-threaded and processes entirely in the real-time audio thread,
@@ skipping 59 matching lines @@
 
 void ConvolverNode::uninitialize()
 {
     if (!isInitialized())
         return;
 
     m_reverb.clear();
     AudioNode::uninitialize();
 }
 
-void ConvolverNode::setBuffer(AudioBuffer* buffer)
+void ConvolverNode::setBuffer(AudioBuffer* buffer, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
 
     if (!buffer)
         return;
 
+    if (buffer->sampleRate() != context()->sampleRate()) {
+        exceptionState.throwDOMException(
+            NotSupportedError,
+            "The buffer sample rate of " + String::number(buffer->sampleRate())
+            + " does not match the context rate of " + String::number(context()->sampleRate())
+            + " Hz.");
+    }

[tkent, 2015/04/08 04:52:35]

Should we do |return| here?

[Raymond Toy, 2015/04/08 15:49:44]

Yes!

I'll fix this right away.

+
     unsigned numberOfChannels = buffer->numberOfChannels();
     size_t bufferLength = buffer->length();
 
     // The current implementation supports up to four channel impulse responses, which are interpreted as true-stereo (see Reverb class).
     bool isBufferGood = numberOfChannels > 0 && numberOfChannels <= 4 && bufferLength;
     ASSERT(isBufferGood);
     if (!isBufferGood)
         return;
 
     // Wrap the AudioBuffer by an AudioBus. It's an efficient pointer set and not a memcpy().
@@ skipping 38 matching lines @@
     if (tryLocker.locked())
         return m_reverb ? m_reverb->latencyFrames() / static_cast<double>(sampleRate()) : 0;
     // Since we don't want to block the Audio Device thread, we return a large value
     // instead of trying to acquire the lock.
     return std::numeric_limits<double>::infinity();
 }
 
 } // namespace WebCore
 
 #endif // ENABLE(WEB_AUDIO)