Issue 20054003: skpdiff: remove default value for output. Diifs can be very big, and fill a hard drive, no sense to…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20054003: skpdiff: remove default value for output. Diifs can be very big, and fill a hard drive, no sense to… (Closed)

Created:
7 years, 5 months ago by edisonn

Modified:
7 years, 5 months ago

Reviewers:
Zach Reizner, djsollen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

skpdiff: remove default value for output. Diifs can be very big, and fill a hard drive, no sense to generate them if not needed. R=zachr@google.com Committed: https://code.google.com/p/skia/source/detail?r=10291

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/skpdiff/skpdiff_main.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

edisonn

7 years, 5 months ago (2013-07-23 20:15:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r10291 (presubmit successful).