mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart - Issue 2005343003: Mojom compiler frontend: Change the type of the |offset| field to uint32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart

Issue 2005343003: Mojom compiler frontend: Change the type of the |offset| field to uint32. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/dart/packages/_mojo_for_test_only/lib/test/pingpong_service.mojom.dart ('k') | mojo/public/interfaces/bindings/mojom_types.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart

diff --git a/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart b/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart

index 4ef15b2ad8001dbd34937478d438efed627f7d91..7e8bad24f797228e500c7302b21de40735b9486a 100644

--- a/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart

+++ b/mojo/dart/packages/mojo/lib/mojo/bindings/types/mojom_types.mojom.dart

@@ -829,7 +829,7 @@ class StructField extends bindings.Struct {

}

if (mainDataHeader.version >= 0) {

- result.offset = decoder0.decodeInt32(48);

+ result.offset = decoder0.decodeUint32(48);

}

if (mainDataHeader.version >= 0) {

@@ -866,7 +866,7 @@ class StructField extends bindings.Struct {

rethrow;

}

try {

- encoder0.encodeInt32(offset, 48);

+ encoder0.encodeUint32(offset, 48);

} on bindings.MojoCodecError catch(e) {

e.message = "Error encountered while encoding field "

"offset of struct StructField: $e";