swarmbucket: add get_builders api

swarmbucket: add get_builders api

Rietveld needs to discover new builders. Add swarmbucket API to expose
builders.

R=estaab@chromium.org, vadimsh@chromium.org
BUG=613647
Committed: https://chromium.googlesource.com/infra/infra/+/fdbf2fbdcbf5fb950444ba5dade2a262e7f5e1fc

[nodir, 2016-05-24 19:10:43]

PTAL

Deployed:
https://apis-explorer.appspot.com/apis-explorer/?base=https://4096-5578382-ta...

[Vadim Sh., 2016-05-24 19:22:59]

lgtm with questions

https://codereview.chromium.org/2005333002/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/swarming/swarmbucket_api.py (right):

https://codereview.chromium.org/2005333002/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/swarming/swarmbucket_api.py:62: def get_builders(self,
_request):
no arguments? How would we support different projects (that need different set
of builders)?

Also, is it really swarming specific? Can't it replace current halfassed
rietveld builder config mechanism for CQ builders? (Or it was fixed already?)

[nodir, 2016-05-24 19:36:54]

https://codereview.chromium.org/2005333002/diff/20001/appengine/cr-buildbucke...
File appengine/cr-buildbucket/swarming/swarmbucket_api.py (right):

https://codereview.chromium.org/2005333002/diff/20001/appengine/cr-buildbucke...
appengine/cr-buildbucket/swarming/swarmbucket_api.py:62: def get_builders(self,
_request):
On 2016/05/24 19:22:59, Vadim Sh. wrote:
> no arguments? How would we support different projects (that need different set
> of builders)?

I added "bucket" parameter initially, and then deleted it. Currently we don't
have a use case that needs filtering and filtering can be always added later.
 
> Also, is it really swarming specific? 

it is swarmbucket-specific because, but in general concepts "builder" and
"category" are well-established across infra.

>Can't it replace current halfassed
> rietveld builder config mechanism for CQ builders? (Or it was fixed already?)

Eventually? Maybe. My plan is to fetch builders from this endpoints _in
addition_ to existing mechanisms.

[nodir, 2016-05-24 21:17:36]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-05-24 21:17:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005333002/20001

[commit-bot: I haz the power, 2016-05-24 21:21:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-24 21:21:30]

Try jobs failed on following builders:
  Infra Linux Trusty 64 Tester on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Infra%20Linux%20Trusty%...)

[nodir, 2016-05-24 21:50:13]

Patchset #4 (id:60001) has been deleted

[nodir, 2016-05-24 21:51:27]

Patchset #3 (id:40001) has been deleted

[nodir, 2016-05-24 21:51:38]

The CQ bit was checked by nodir@chromium.org

[nodir, 2016-05-24 21:51:39]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/2005333002/#ps80001
(title: "fix tests")

[commit-bot: I haz the power, 2016-05-24 21:51:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2005333002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2005333002/80001

[commit-bot: I haz the power, 2016-05-24 21:55:45]

Description was changed from

==========
swarmbucket: add get_builders api

Rietveld needs to discover new builders. Add swarmbucket API to expose
builders.

R=estaab@chromium.org, vadimsh@chromium.org
BUG=613647
==========

to

==========
swarmbucket: add get_builders api

Rietveld needs to discover new builders. Add swarmbucket API to expose
builders.

R=estaab@chromium.org, vadimsh@chromium.org
BUG=613647

Committed:
https://chromium.googlesource.com/infra/infra/+/fdbf2fbdcbf5fb950444ba5dade2a...
==========

[commit-bot: I haz the power, 2016-05-24 21:55:46]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/infra/infra/+/fdbf2fbdcbf5fb950444ba5dade2a...