Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2005323002: Remove ContextMenuController. (Closed)

Created:
4 years, 7 months ago by michaeldo
Modified:
4 years, 7 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@contextMenuWrangler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextMenuController. Remove ContextMenuController and ContextMenuHolder objects as well as the ContextMenuProvider protocol. These are being removed in favor of ContextMenuCoordinator. BUG=none Committed: https://crrev.com/1f5ddcc64b6b8fa6b10c67c704c4f48fde4e3ad0 Cr-Commit-Position: refs/heads/master@{#395731}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -337 lines) Patch
M ios/chrome/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
D ios/chrome/browser/ui/context_menu/context_menu_controller.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ios/chrome/browser/ui/context_menu/context_menu_controller.mm View 1 chunk +0 lines, -87 lines 0 comments Download
D ios/chrome/browser/ui/context_menu/context_menu_controller_unittest.mm View 1 chunk +0 lines, -58 lines 0 comments Download
D ios/chrome/browser/ui/context_menu/context_menu_holder.h View 1 chunk +0 lines, -47 lines 0 comments Download
D ios/chrome/browser/ui/context_menu/context_menu_holder.mm View 1 chunk +0 lines, -74 lines 0 comments Download
D ios/chrome/browser/ui/context_menu/context_menu_provider.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M ios/chrome/ios_chrome_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (9 generated)
michaeldo
4 years, 7 months ago (2016-05-24 18:41:55 UTC) #2
Jackie Quinn
lgtm
4 years, 7 months ago (2016-05-24 18:50:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005323002/1
4 years, 7 months ago (2016-05-24 21:57:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/189130)
4 years, 7 months ago (2016-05-24 22:07:13 UTC) #8
Eugene But (OOO till 7-30)
lgtm
4 years, 7 months ago (2016-05-24 23:16:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005323002/1
4 years, 7 months ago (2016-05-24 23:16:36 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 23:26:58 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 23:28:29 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f5ddcc64b6b8fa6b10c67c704c4f48fde4e3ad0
Cr-Commit-Position: refs/heads/master@{#395731}

Powered by Google App Engine
This is Rietveld 408576698