Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: pkg/compiler/lib/src/serialization/modelz.dart

Issue 2005293003: Compute import paths using ImportElement and ExportElement (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Compute members eagerly. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/library_loader.dart ('k') | tests/compiler/dart2js/serialization/test_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/serialization/modelz.dart
diff --git a/pkg/compiler/lib/src/serialization/modelz.dart b/pkg/compiler/lib/src/serialization/modelz.dart
index ef385bba54e2e94665107003d05d5787f7ee5361..08f5c7e0c42538847248a5b8746884cfa4f108d0 100644
--- a/pkg/compiler/lib/src/serialization/modelz.dart
+++ b/pkg/compiler/lib/src/serialization/modelz.dart
@@ -846,8 +846,10 @@ abstract class ClassElementMixin
void ensureResolved(Resolution resolution) {
if (!_isResolved) {
_isResolved = true;
- class_members.MembersCreator
- .computeClassMembersByName(resolution, this, Identifiers.call);
+ // TODO(johnniwinther): Avoid eager computation of all members. `call` is
+ // always needed, but the remaining should be computed on-demand or on
+ // type instantiation.
Siggi Cherem (dart-lang) 2016/05/26 22:38:08 nit: fix indent
Johnni Winther 2016/05/27 08:52:25 Done.
+ class_members.MembersCreator.computeAllClassMembers(resolution, this);
resolution.registerClass(this);
}
}
« no previous file with comments | « pkg/compiler/lib/src/library_loader.dart ('k') | tests/compiler/dart2js/serialization/test_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698