Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2005293003: Compute import paths using ImportElement and ExportElement (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 6 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Compute import paths using ImportElement and ExportElement BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/d78290a5b2820ccaa6fe09ca6eaa5795c3b218ee

Patch Set 1 #

Patch Set 2 : Compute members eagerly. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M pkg/compiler/lib/src/library_loader.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 1 chunk +4 lines, -2 lines 2 comments Download
M tests/compiler/dart2js/serialization/test_data.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-26 12:31:20 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2005293003/diff/20001/pkg/compiler/lib/src/serialization/modelz.dart File pkg/compiler/lib/src/serialization/modelz.dart (right): https://codereview.chromium.org/2005293003/diff/20001/pkg/compiler/lib/src/serialization/modelz.dart#newcode851 pkg/compiler/lib/src/serialization/modelz.dart:851: // type instantiation. nit: fix indent
4 years, 7 months ago (2016-05-26 22:38:08 UTC) #3
Johnni Winther
https://codereview.chromium.org/2005293003/diff/20001/pkg/compiler/lib/src/serialization/modelz.dart File pkg/compiler/lib/src/serialization/modelz.dart (right): https://codereview.chromium.org/2005293003/diff/20001/pkg/compiler/lib/src/serialization/modelz.dart#newcode851 pkg/compiler/lib/src/serialization/modelz.dart:851: // type instantiation. On 2016/05/26 22:38:08, Siggi Cherem (dart-lang) ...
4 years, 6 months ago (2016-05-27 08:52:25 UTC) #4
Johnni Winther
4 years, 6 months ago (2016-05-27 08:58:58 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
d78290a5b2820ccaa6fe09ca6eaa5795c3b218ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698