Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/loader/mime_type_resource_handler_unittest.cc

Issue 2005273002: Move MimeTypeResourceHandler before ThrottlingResourceHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/loader/mime_sniffing_resource_handler_unittest.cc ('K') | « content/browser/loader/mime_type_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/loader/mime_type_resource_handler_unittest.cc
diff --git a/content/browser/loader/mime_type_resource_handler_unittest.cc b/content/browser/loader/mime_type_resource_handler_unittest.cc
deleted file mode 100644
index 6bed3a84943e687afdae7da24ee34929042361b8..0000000000000000000000000000000000000000
--- a/content/browser/loader/mime_type_resource_handler_unittest.cc
+++ /dev/null
@@ -1,466 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "content/browser/loader/mime_type_resource_handler.h"
-
-#include <stdint.h>
-
-#include <memory>
-
-#include "base/files/file_path.h"
-#include "base/location.h"
-#include "base/logging.h"
-#include "base/macros.h"
-#include "base/single_thread_task_runner.h"
-#include "base/threading/thread_task_runner_handle.h"
-#include "content/browser/loader/resource_dispatcher_host_impl.h"
-#include "content/public/browser/resource_controller.h"
-#include "content/public/browser/resource_dispatcher_host_delegate.h"
-#include "content/public/browser/resource_request_info.h"
-#include "content/public/common/resource_response.h"
-#include "content/public/common/webplugininfo.h"
-#include "content/public/test/test_browser_thread_bundle.h"
-#include "content/public/test/test_utils.h"
-#include "content/test/fake_plugin_service.h"
-#include "net/url_request/url_request_context.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "url/gurl.h"
-
-namespace content {
-
-namespace {
-
-class TestResourceHandler : public ResourceHandler {
- public:
- TestResourceHandler() : ResourceHandler(nullptr) {}
-
- void SetController(ResourceController* controller) override {}
-
- bool OnRequestRedirected(const net::RedirectInfo& redirect_info,
- ResourceResponse* response,
- bool* defer) override {
- NOTREACHED();
- return false;
- }
-
- bool OnResponseStarted(ResourceResponse* response, bool* defer) override {
- return false;
- }
-
- bool OnWillStart(const GURL& url, bool* defer) override {
- return false;
- }
-
- bool OnBeforeNetworkStart(const GURL& url, bool* defer) override {
- NOTREACHED();
- return false;
- }
-
- bool OnWillRead(scoped_refptr<net::IOBuffer>* buf,
- int* buf_size,
- int min_size) override {
- NOTREACHED();
- return false;
- }
-
- bool OnReadCompleted(int bytes_read, bool* defer) override {
- NOTREACHED();
- return false;
- }
-
- void OnResponseCompleted(const net::URLRequestStatus& status,
- const std::string& security_info,
- bool* defer) override {
- }
-
- void OnDataDownloaded(int bytes_downloaded) override {
- NOTREACHED();
- }
-
- private:
- DISALLOW_COPY_AND_ASSIGN(TestResourceHandler);
-};
-
-class TestResourceDispatcherHost : public ResourceDispatcherHostImpl {
- public:
- explicit TestResourceDispatcherHost(bool stream_has_handler)
- : stream_has_handler_(stream_has_handler),
- intercepted_as_stream_(false),
- intercepted_as_stream_count_(0) {}
-
- bool intercepted_as_stream() const { return intercepted_as_stream_; }
-
- std::unique_ptr<ResourceHandler> CreateResourceHandlerForDownload(
- net::URLRequest* request,
- bool is_content_initiated,
- bool must_download) override {
- return std::unique_ptr<ResourceHandler>(new TestResourceHandler);
- }
-
- std::unique_ptr<ResourceHandler> MaybeInterceptAsStream(
- const base::FilePath& plugin_path,
- net::URLRequest* request,
- ResourceResponse* response,
- std::string* payload) override {
- intercepted_as_stream_count_++;
- if (stream_has_handler_) {
- intercepted_as_stream_ = true;
- return std::unique_ptr<ResourceHandler>(new TestResourceHandler);
- } else {
- return std::unique_ptr<ResourceHandler>();
- }
- }
-
- int intercepted_as_stream_count() const {
- return intercepted_as_stream_count_;
- }
-
- private:
- // Whether the URL request should be intercepted as a stream.
- bool stream_has_handler_;
-
- // Whether the URL request has been intercepted as a stream.
- bool intercepted_as_stream_;
-
- // Count of number of times MaybeInterceptAsStream function get called in a
- // test.
- int intercepted_as_stream_count_;
-};
-
-class TestResourceDispatcherHostDelegate
- : public ResourceDispatcherHostDelegate {
- public:
- TestResourceDispatcherHostDelegate(bool must_download)
- : must_download_(must_download) {
- }
-
- bool ShouldForceDownloadResource(const GURL& url,
- const std::string& mime_type) override {
- return must_download_;
- }
-
- private:
- const bool must_download_;
-};
-
-class TestResourceController : public ResourceController {
- public:
- void Cancel() override {}
-
- void CancelAndIgnore() override {
- NOTREACHED();
- }
-
- void CancelWithError(int error_code) override {
- NOTREACHED();
- }
-
- void Resume() override {
- NOTREACHED();
- }
-};
-
-class TestFakePluginService : public FakePluginService {
- public:
- // If |is_plugin_stale| is true, GetPluginInfo will indicate the plugins are
- // stale until GetPlugins is called.
- TestFakePluginService(bool plugin_available, bool is_plugin_stale)
- : plugin_available_(plugin_available),
- is_plugin_stale_(is_plugin_stale) {}
-
- bool GetPluginInfo(int render_process_id,
- int render_frame_id,
- ResourceContext* context,
- const GURL& url,
- const GURL& page_url,
- const std::string& mime_type,
- bool allow_wildcard,
- bool* is_stale,
- WebPluginInfo* info,
- std::string* actual_mime_type) override {
- *is_stale = is_plugin_stale_;
- if (!is_plugin_stale_ || !plugin_available_)
- return false;
- info->type = WebPluginInfo::PLUGIN_TYPE_BROWSER_PLUGIN;
- info->path = base::FilePath::FromUTF8Unsafe(
- std::string("chrome-extension://mhjfbmdgcfjbbpaeojofohoefgiehjai/"));
- return true;
- }
-
- void GetPlugins(const GetPluginsCallback& callback) override {
- is_plugin_stale_ = false;
- std::vector<WebPluginInfo> plugins;
- base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE, base::Bind(callback, plugins));
- }
-
- private:
- const bool plugin_available_;
- bool is_plugin_stale_;
-
- DISALLOW_COPY_AND_ASSIGN(TestFakePluginService);
-};
-
-class MimeTypeResourceHandlerTest : public testing::Test {
- public:
- MimeTypeResourceHandlerTest()
- : stream_has_handler_(false),
- plugin_available_(false),
- plugin_stale_(false) {}
-
- void set_stream_has_handler(bool stream_has_handler) {
- stream_has_handler_ = stream_has_handler;
- }
-
- void set_plugin_available(bool plugin_available) {
- plugin_available_ = plugin_available;
- }
-
- void set_plugin_stale(bool plugin_stale) { plugin_stale_ = plugin_stale; }
-
- bool TestStreamIsIntercepted(bool allow_download,
- bool must_download,
- ResourceType request_resource_type);
-
- std::string TestAcceptHeaderSetting(ResourceType request_resource_type);
- std::string TestAcceptHeaderSettingWithURLRequest(
- ResourceType request_resource_type,
- net::URLRequest* request);
-
- private:
- // Whether the URL request should be intercepted as a stream.
- bool stream_has_handler_;
- bool plugin_available_;
- bool plugin_stale_;
-
- TestBrowserThreadBundle thread_bundle_;
-};
-
-bool MimeTypeResourceHandlerTest::TestStreamIsIntercepted(
- bool allow_download,
- bool must_download,
- ResourceType request_resource_type) {
- net::URLRequestContext context;
- std::unique_ptr<net::URLRequest> request(context.CreateRequest(
- GURL("http://www.google.com"), net::DEFAULT_PRIORITY, nullptr));
- bool is_main_frame = request_resource_type == RESOURCE_TYPE_MAIN_FRAME;
- ResourceRequestInfo::AllocateForTesting(
- request.get(),
- request_resource_type,
- nullptr, // context
- 0, // render_process_id
- 0, // render_view_id
- 0, // render_frame_id
- is_main_frame, // is_main_frame
- false, // parent_is_main_frame
- allow_download, // allow_download
- true, // is_async
- false); // is_using_lofi
-
- TestResourceDispatcherHost host(stream_has_handler_);
- TestResourceDispatcherHostDelegate host_delegate(must_download);
- host.SetDelegate(&host_delegate);
-
- TestFakePluginService plugin_service(plugin_available_, plugin_stale_);
- std::unique_ptr<ResourceHandler> mime_sniffing_handler(
- new MimeTypeResourceHandler(
- std::unique_ptr<ResourceHandler>(new TestResourceHandler()), &host,
- &plugin_service, request.get()));
- TestResourceController resource_controller;
- mime_sniffing_handler->SetController(&resource_controller);
-
- scoped_refptr<ResourceResponse> response(new ResourceResponse);
- // The MIME type isn't important but it shouldn't be empty.
- response->head.mime_type = "application/pdf";
-
- bool defer = false;
- mime_sniffing_handler->OnResponseStarted(response.get(), &defer);
-
- content::RunAllPendingInMessageLoop();
- EXPECT_LT(host.intercepted_as_stream_count(), 2);
- return host.intercepted_as_stream();
-}
-
-std::string MimeTypeResourceHandlerTest::TestAcceptHeaderSetting(
- ResourceType request_resource_type) {
- net::URLRequestContext context;
- std::unique_ptr<net::URLRequest> request(context.CreateRequest(
- GURL("http://www.google.com"), net::DEFAULT_PRIORITY, nullptr));
- return TestAcceptHeaderSettingWithURLRequest(
- request_resource_type, request.get());
-}
-
-std::string MimeTypeResourceHandlerTest::TestAcceptHeaderSettingWithURLRequest(
- ResourceType request_resource_type,
- net::URLRequest* request) {
- bool is_main_frame = request_resource_type == RESOURCE_TYPE_MAIN_FRAME;
- ResourceRequestInfo::AllocateForTesting(
- request,
- request_resource_type,
- nullptr, // context
- 0, // render_process_id
- 0, // render_view_id
- 0, // render_frame_id
- is_main_frame, // is_main_frame
- false, // parent_is_main_frame
- false, // allow_download
- true, // is_async
- false); // is_using_lofi
-
- TestResourceDispatcherHost host(stream_has_handler_);
- TestResourceDispatcherHostDelegate host_delegate(false);
- host.SetDelegate(&host_delegate);
-
- std::unique_ptr<ResourceHandler> mime_sniffing_handler(
- new MimeTypeResourceHandler(
- std::unique_ptr<ResourceHandler>(new TestResourceHandler()), &host,
- nullptr, request));
-
- bool defer = false;
- mime_sniffing_handler->OnWillStart(request->url(), &defer);
- content::RunAllPendingInMessageLoop();
-
- std::string accept_header;
- request->extra_request_headers().GetHeader("Accept", &accept_header);
- return accept_header;
-}
-
-// Test that the proper Accept: header is set based on the ResourceType
-TEST_F(MimeTypeResourceHandlerTest, AcceptHeaders) {
- EXPECT_EQ(
- "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,"
- "*/*;q=0.8",
- TestAcceptHeaderSetting(RESOURCE_TYPE_MAIN_FRAME));
- EXPECT_EQ(
- "text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,"
- "*/*;q=0.8",
- TestAcceptHeaderSetting(RESOURCE_TYPE_SUB_FRAME));
- EXPECT_EQ("text/css,*/*;q=0.1",
- TestAcceptHeaderSetting(RESOURCE_TYPE_STYLESHEET));
- EXPECT_EQ("*/*",
- TestAcceptHeaderSetting(RESOURCE_TYPE_SCRIPT));
- EXPECT_EQ("image/webp,image/*,*/*;q=0.8",
- TestAcceptHeaderSetting(RESOURCE_TYPE_IMAGE));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_FONT_RESOURCE));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_SUB_RESOURCE));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_OBJECT));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_MEDIA));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_WORKER));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_SHARED_WORKER));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_PREFETCH));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_FAVICON));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_XHR));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_PING));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_SERVICE_WORKER));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_CSP_REPORT));
- EXPECT_EQ("*/*", TestAcceptHeaderSetting(RESOURCE_TYPE_PLUGIN_RESOURCE));
-
- // Ensure that if an Accept header is already set, it is not overwritten.
- net::URLRequestContext context;
- std::unique_ptr<net::URLRequest> request(context.CreateRequest(
- GURL("http://www.google.com"), net::DEFAULT_PRIORITY, nullptr));
- request->SetExtraRequestHeaderByName("Accept", "*", true);
- EXPECT_EQ("*",
- TestAcceptHeaderSettingWithURLRequest(RESOURCE_TYPE_XHR, request.get()));
-}
-
-// Test that stream requests are correctly intercepted under the right
-// circumstances. Test is not relevent when plugins are disabled.
-#if defined(ENABLE_PLUGINS)
-TEST_F(MimeTypeResourceHandlerTest, StreamHandling) {
- bool allow_download;
- bool must_download;
- ResourceType resource_type;
-
- // Ensure the stream is handled by MaybeInterceptAsStream in the
- // ResourceDispatcherHost.
- set_stream_has_handler(true);
- set_plugin_available(true);
-
- // Main frame request with no download allowed. Stream shouldn't be
- // intercepted.
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_MAIN_FRAME;
- EXPECT_FALSE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Main frame request with download allowed. Stream should be intercepted.
- allow_download = true;
- must_download = false;
- resource_type = RESOURCE_TYPE_MAIN_FRAME;
- EXPECT_TRUE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Main frame request with download forced. Stream shouldn't be intercepted.
- allow_download = true;
- must_download = true;
- resource_type = RESOURCE_TYPE_MAIN_FRAME;
- EXPECT_FALSE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Sub-resource request with download not allowed. Stream shouldn't be
- // intercepted.
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_SUB_RESOURCE;
- EXPECT_FALSE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Plugin resource request with download not allowed. Stream shouldn't be
- // intercepted.
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_PLUGIN_RESOURCE;
- EXPECT_FALSE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Object request with download not allowed. Stream should be intercepted.
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_OBJECT;
- EXPECT_TRUE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Test the cases where the stream isn't handled by MaybeInterceptAsStream
- // in the ResourceDispatcherHost.
- set_stream_has_handler(false);
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_OBJECT;
- EXPECT_FALSE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- allow_download = true;
- must_download = false;
- resource_type = RESOURCE_TYPE_MAIN_FRAME;
- EXPECT_FALSE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Test the cases where the stream handled by MaybeInterceptAsStream
- // with plugin not available. This is the case when intercepting streams for
- // the streamsPrivate extensions API.
- set_stream_has_handler(true);
- set_plugin_available(false);
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_OBJECT;
- EXPECT_TRUE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-
- // Test the cases where the stream handled by MaybeInterceptAsStream
- // with plugin not available. This is the case when intercepting streams for
- // the streamsPrivate extensions API with stale plugin.
- set_plugin_stale(true);
- allow_download = false;
- must_download = false;
- resource_type = RESOURCE_TYPE_OBJECT;
- EXPECT_TRUE(
- TestStreamIsIntercepted(allow_download, must_download, resource_type));
-}
-#endif
-
-} // namespace
-
-} // namespace content
« content/browser/loader/mime_sniffing_resource_handler_unittest.cc ('K') | « content/browser/loader/mime_type_resource_handler.cc ('k') | content/browser/loader/resource_dispatcher_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698