Issue 2005263002: SkColorSpace tweaks

Issue 2005263002: SkColorSpace tweaks (Closed)

Created:
4 years, 7 months ago by msarett

Modified:
4 years, 7 months ago

Reviewers:
scroggo, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

SkColorSpace tweaks ***Move includes to the correct file ***Add "const" ***Use std::move for more efficient refs and unrefs BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2005263002 Committed: https://skia.googlesource.com/skia/+/e077e0683a6fe79f71f3e3762edb259941431ada

Patch Set 1 #

Patch Set 2 : #

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
M	include/core/SkColorSpace.h	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/core/SkColorSpace.cpp	View		5 chunks	+9 lines, -9 lines	0 comments	Download
M	src/core/SkColorSpace_Base.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/ColorSpaceTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005263002/20001

4 years, 7 months ago (2016-05-24 17:01:39 UTC) #7

commit-bot: I haz the power

4 years, 7 months ago (2016-05-24 17:16:56 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/e077e0683a6fe79f71f3e3762edb259941431ada

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages