Chromium Code Reviews| Index: tools/perf/benchmarks/memory_infra.py |
| diff --git a/tools/perf/benchmarks/memory_infra.py b/tools/perf/benchmarks/memory_infra.py |
| index 4672f73bf25dc4e5c0547c6afd10ba549efe71e7..c1fe0e773127f4b7a573b3867b102b5289395b3e 100644 |
| --- a/tools/perf/benchmarks/memory_infra.py |
| +++ b/tools/perf/benchmarks/memory_infra.py |
| @@ -14,6 +14,9 @@ from telemetry.web_perf.metrics import memory_timeline |
| import page_sets |
| +_IGNORED_STATS_RE = re.compile(r'_(std|count|max|min|sum|pct_\d{4}(_\d+)?)$') |
|
petrcermak
2016/05/24 12:36:54
It might be worth saying something like "See tr.v.
perezju
2016/05/24 13:16:46
Done.
|
| + |
| + |
| class _MemoryInfra(perf_benchmark.PerfBenchmark): |
| """Base class for new-generation memory benchmarks based on memory-infra. |
| @@ -89,6 +92,12 @@ class TBMv2MemoryBenchmarkTop10Mobile(MemoryHealthPlan): |
| def Name(cls): |
| return 'memory.top_10_mobile_tbmv2' |
| + @classmethod |
| + def ValueCanBeAddedPredicate(cls, value, is_first_result): |
| + # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard |
| + # is able to cope with the data load generated by TBMv2 metrics. |
| + return not _IGNORED_STATS_RE.search(value.name) |
| + |
| # Benchmark is disabled by default because it takes too long to run. |
| @benchmark.Disabled('all') |
| @@ -107,6 +116,12 @@ class DualBrowserBenchmark(_MemoryInfra): |
| def Name(cls): |
| return 'memory.dual_browser_test' |
| + @classmethod |
| + def ValueCanBeAddedPredicate(cls, value, is_first_result): |
| + # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard |
| + # is able to cope with the data load generated by TBMv2 metrics. |
| + return not _IGNORED_STATS_RE.search(value.name) |
| + |
| # TODO(bashi): Workaround for http://crbug.com/532075 |
| # @benchmark.Enabled('android') shouldn't be needed. |