Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2005203002: Make CSSParserImpl::m_context a const reference to avoid copies (Closed)

Created:
4 years, 7 months ago by Timothy Loh
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSParserImpl::m_context a const reference to avoid copies BUG=605792 Committed: https://crrev.com/1f192ea58ce279fd382efd3a362f8afff9f79cc1 Cr-Commit-Position: refs/heads/master@{#395821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/parser/CSSParserImpl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Timothy Loh
4 years, 7 months ago (2016-05-24 08:52:24 UTC) #2
alancutter (OOO until 2018)
lgtm
4 years, 7 months ago (2016-05-25 07:00:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005203002/1
4 years, 7 months ago (2016-05-25 07:17:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 07:21:52 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 07:23:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1f192ea58ce279fd382efd3a362f8afff9f79cc1
Cr-Commit-Position: refs/heads/master@{#395821}

Powered by Google App Engine
This is Rietveld 408576698