Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/heap/scavenger-inl.h

Issue 2005173003: Immediatelly promote marked objects (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Really should concentrate more Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/scavenger.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_HEAP_SCAVENGER_INL_H_ 5 #ifndef V8_HEAP_SCAVENGER_INL_H_
6 #define V8_HEAP_SCAVENGER_INL_H_ 6 #define V8_HEAP_SCAVENGER_INL_H_
7 7
8 #include "src/heap/scavenger.h" 8 #include "src/heap/scavenger.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 12
13 void Scavenger::ScavengeObject(HeapObject** p, HeapObject* object, 13 void Scavenger::ScavengeObject(HeapObject** p, HeapObject* object) {
14 PromotionMode promotion_mode) {
15 DCHECK(object->GetIsolate()->heap()->InFromSpace(object)); 14 DCHECK(object->GetIsolate()->heap()->InFromSpace(object));
16 15
17 // We use the first word (where the map pointer usually is) of a heap 16 // We use the first word (where the map pointer usually is) of a heap
18 // object to record the forwarding pointer. A forwarding pointer can 17 // object to record the forwarding pointer. A forwarding pointer can
19 // point to an old space, the code space, or the to space of the new 18 // point to an old space, the code space, or the to space of the new
20 // generation. 19 // generation.
21 MapWord first_word = object->map_word(); 20 MapWord first_word = object->map_word();
22 21
23 // If the first word is a forwarding address, the object has already been 22 // If the first word is a forwarding address, the object has already been
24 // copied. 23 // copied.
25 if (first_word.IsForwardingAddress()) { 24 if (first_word.IsForwardingAddress()) {
26 HeapObject* dest = first_word.ToForwardingAddress(); 25 HeapObject* dest = first_word.ToForwardingAddress();
27 DCHECK(object->GetIsolate()->heap()->InFromSpace(*p)); 26 DCHECK(object->GetIsolate()->heap()->InFromSpace(*p));
28 *p = dest; 27 *p = dest;
29 return; 28 return;
30 } 29 }
31 30
32 object->GetHeap()->UpdateAllocationSite<Heap::kGlobal>( 31 object->GetHeap()->UpdateAllocationSite<Heap::kGlobal>(
33 object, object->GetHeap()->global_pretenuring_feedback_); 32 object, object->GetHeap()->global_pretenuring_feedback_);
34 33
35 // AllocationMementos are unrooted and shouldn't survive a scavenge 34 // AllocationMementos are unrooted and shouldn't survive a scavenge
36 DCHECK(object->map() != object->GetHeap()->allocation_memento_map()); 35 DCHECK(object->map() != object->GetHeap()->allocation_memento_map());
37 // Call the slow part of scavenge object. 36 // Call the slow part of scavenge object.
38 return ScavengeObjectSlow(p, object, promotion_mode); 37 return ScavengeObjectSlow(p, object);
39 } 38 }
40 39
41 SlotCallbackResult Scavenger::CheckAndScavengeObject( 40 SlotCallbackResult Scavenger::CheckAndScavengeObject(Heap* heap,
42 Heap* heap, Address slot_address, PromotionMode promotion_mode) { 41 Address slot_address) {
43 Object** slot = reinterpret_cast<Object**>(slot_address); 42 Object** slot = reinterpret_cast<Object**>(slot_address);
44 Object* object = *slot; 43 Object* object = *slot;
45 if (heap->InFromSpace(object)) { 44 if (heap->InFromSpace(object)) {
46 HeapObject* heap_object = reinterpret_cast<HeapObject*>(object); 45 HeapObject* heap_object = reinterpret_cast<HeapObject*>(object);
47 DCHECK(heap_object->IsHeapObject()); 46 DCHECK(heap_object->IsHeapObject());
48 47
49 ScavengeObject(reinterpret_cast<HeapObject**>(slot), heap_object, 48 ScavengeObject(reinterpret_cast<HeapObject**>(slot), heap_object);
50 promotion_mode);
51 49
52 object = *slot; 50 object = *slot;
53 // If the object was in from space before and is after executing the 51 // If the object was in from space before and is after executing the
54 // callback in to space, the object is still live. 52 // callback in to space, the object is still live.
55 // Unfortunately, we do not know about the slot. It could be in a 53 // Unfortunately, we do not know about the slot. It could be in a
56 // just freed free space object. 54 // just freed free space object.
57 if (heap->InToSpace(object)) { 55 if (heap->InToSpace(object)) {
58 return KEEP_SLOT; 56 return KEEP_SLOT;
59 } 57 }
60 } else { 58 } else {
61 DCHECK(!heap->InNewSpace(object)); 59 DCHECK(!heap->InNewSpace(object));
62 } 60 }
63 return REMOVE_SLOT; 61 return REMOVE_SLOT;
64 } 62 }
65 63
66 // static 64 // static
67 void StaticScavengeVisitor::VisitPointer(Heap* heap, HeapObject* obj, 65 template <PromotionMode promotion_mode>
68 Object** p) { 66 void StaticScavengeVisitor<promotion_mode>::VisitPointer(Heap* heap,
67 HeapObject* obj,
68 Object** p) {
69 Object* object = *p; 69 Object* object = *p;
70 if (!heap->InNewSpace(object)) return; 70 if (!heap->InNewSpace(object)) return;
71 Scavenger::ScavengeObject(reinterpret_cast<HeapObject**>(p), 71 Scavenger::ScavengeObject(reinterpret_cast<HeapObject**>(p),
72 reinterpret_cast<HeapObject*>(object), 72 reinterpret_cast<HeapObject*>(object));
73 DEFAULT_PROMOTION);
74 } 73 }
75 74
76 } // namespace internal 75 } // namespace internal
77 } // namespace v8 76 } // namespace v8
78 77
79 #endif // V8_HEAP_SCAVENGER_INL_H_ 78 #endif // V8_HEAP_SCAVENGER_INL_H_
OLDNEW
« no previous file with comments | « src/heap/scavenger.cc ('k') | test/cctest/heap/test-heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698