Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2005143005: Record network quality UMA metrics on main frame requests (Closed)

Created:
4 years, 7 months ago by tbansal1
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record network quality UMA metrics on main frame requests BUG=614572 Committed: https://crrev.com/dae311a51d9bba99bd934fd25f8d8d48b2da7eec Cr-Commit-Position: refs/heads/master@{#396875}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Fixed rebase issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -1 line) Patch
M net/nqe/network_quality_estimator.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator.cc View 1 2 2 chunks +31 lines, -0 lines 0 comments Download
M net/nqe/network_quality_estimator_unittest.cc View 1 4 chunks +14 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 3 chunks +42 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
tbansal1
bengr: ptal. Thanks.
4 years, 7 months ago (2016-05-25 01:16:52 UTC) #4
bengr
lgtm
4 years, 6 months ago (2016-05-27 19:49:33 UTC) #5
tbansal1
asvitkine: PTAL at histograms.xml. Thanks.
4 years, 6 months ago (2016-05-27 21:03:47 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-05-30 14:59:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005143005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005143005/40001
4 years, 6 months ago (2016-05-31 17:47:19 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-31 18:41:07 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:42:14 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dae311a51d9bba99bd934fd25f8d8d48b2da7eec
Cr-Commit-Position: refs/heads/master@{#396875}

Powered by Google App Engine
This is Rietveld 408576698