Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/dom/scripts/generator.py

Issue 2005143004: Add back in pure_interfaces list that turned out to still be needed. The checked in generated code … (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/generator.py
diff --git a/tools/dom/scripts/generator.py b/tools/dom/scripts/generator.py
index 125d64a040bb466b4b3b2f89a50b9450633c6ee9..db475215bd8d506cb8f9d5637be2b4ea822a4cf5 100644
--- a/tools/dom/scripts/generator.py
+++ b/tools/dom/scripts/generator.py
@@ -14,6 +14,46 @@ import re
from htmlrenamer import custom_html_constructors, html_interface_renames, \
typed_array_renames
+_pure_interfaces = monitored.Set('generator._pure_interfaces', [
+ 'AbstractWorker',
+ 'CanvasPathMethods',
+ 'ChildNode',
+ 'DocumentAnimation',
+ 'DocumentFontFaceSet',
+ 'DocumentFullscreen',
+ 'DocumentXPathEvaluator',
+ 'ElementAnimation',
+ 'ElementFullscreen',
+ 'EventListener',
+ 'GlobalEventHandlers',
+ 'ImageBitmapFactories',
+ 'MediaQueryListListener',
+ 'MouseEventHitRegion',
+ 'MutationCallback',
+ 'NavigatorCPU',
+ 'NavigatorEvents',
+ 'NavigatorID',
+ 'NavigatorLanguage',
+ 'NavigatorOnLine',
+ 'ParentNode',
+ 'SVGDocument',
+ 'SVGExternalResourcesRequired',
+ 'SVGFilterPrimitiveStandardAttributes',
+ 'SVGFitToViewBox',
+ 'SVGTests',
+ 'SVGURIReference',
+ 'SVGZoomAndPan',
+ 'TimeoutHandler',
+ 'URLUtils',
+ 'URLUtilsReadOnly',
+ 'WebGLRenderingContextBase',
+ 'WindowBase64',
+ 'WindowEventHandlers',
+ 'WindowImageBitmapFactories',
+ 'WindowPagePopup',
+ 'WindowTimers',
+ ])
+
_safe_interfaces = monitored.Set('generator._safe_interfaces', [
'double',
'Float32Array',
@@ -149,6 +189,8 @@ _safe_interfaces_legacy = monitored.Set('generator._safe_interfaces_legacy', [
# SpeechGrammarList and friends
def IsPureInterface(interface_name, database):
+ if (interface_name in _pure_interfaces):
+ return True
if (interface_name in _safe_interfaces or
interface_name in _safe_interfaces_legacy or
database.HasInterface(interface_name)):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698