Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2005143002: Fix mus_demo (Closed)

Created:
4 years, 7 months ago by rjkroege
Modified:
4 years, 7 months ago
Reviewers:
kylechar
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix mus_demo mus_demo was using the CreateWindowTreeHost to obtain a root window. This interface is intentionally not available on CrOS devices where the idea of a WindowTreeHost as the container for a PlatformWindow does not apply. Switch mus_demo to being a WindowManager implementation so that it works on all mus targets. BUG=611504 Committed: https://crrev.com/64bbb2cf3aa33913002f90ee453c47029b0185f9 Cr-Commit-Position: refs/heads/master@{#395670}

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -12 lines) Patch
M components/mus/demo/manifest.json View 1 chunk +4 lines, -2 lines 0 comments Download
M components/mus/demo/mus_demo.h View 1 4 chunks +11 lines, -2 lines 0 comments Download
M components/mus/demo/mus_demo.cc View 1 5 chunks +21 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
rjkroege
ptal
4 years, 7 months ago (2016-05-24 01:10:28 UTC) #2
kylechar
lgtm with a few nits. https://codereview.chromium.org/2005143002/diff/1/components/mus/demo/mus_demo.cc File components/mus/demo/mus_demo.cc (right): https://codereview.chromium.org/2005143002/diff/1/components/mus/demo/mus_demo.cc#newcode107 components/mus/demo/mus_demo.cc:107: } Nit: Keep the ...
4 years, 7 months ago (2016-05-24 14:38:42 UTC) #3
rjkroege
https://codereview.chromium.org/2005143002/diff/1/components/mus/demo/mus_demo.cc File components/mus/demo/mus_demo.cc (right): https://codereview.chromium.org/2005143002/diff/1/components/mus/demo/mus_demo.cc#newcode107 components/mus/demo/mus_demo.cc:107: } On 2016/05/24 14:38:42, kylechar wrote: > Nit: Keep ...
4 years, 7 months ago (2016-05-24 18:05:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005143002/20001
4 years, 7 months ago (2016-05-24 18:21:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 19:14:05 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 19:17:01 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64bbb2cf3aa33913002f90ee453c47029b0185f9
Cr-Commit-Position: refs/heads/master@{#395670}

Powered by Google App Engine
This is Rietveld 408576698