media/gpu/android_video_decode_accelerator.h - Issue 2005103004: AVDACodecImages keep their backing SurfaceTexture alive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/gpu/android_video_decode_accelerator.h

Issue 2005103004: AVDACodecImages keep their backing SurfaceTexture alive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@neverdetach

Patch Set: Comments and add a DCHECK for glGetError after glDelete Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/gpu/android_video_decode_accelerator.h

diff --git a/media/gpu/android_video_decode_accelerator.h b/media/gpu/android_video_decode_accelerator.h

index d19be2f717a52947359854c687d59d2583e7d07a..6885bdaebbf1e96010820248f11e839e9993eefa 100644

--- a/media/gpu/android_video_decode_accelerator.h

+++ b/media/gpu/android_video_decode_accelerator.h

@@ -144,6 +144,8 @@ class MEDIA_GPU_EXPORT AndroidVideoDecodeAccelerator

base::WeakPtr<gpu::gles2::GLES2Decoder> GetGlDecoder() const override;

gpu::gles2::TextureRef* GetTextureForPicture(

const media::PictureBuffer& picture_buffer) override;

+ scoped_refptr<gl::SurfaceTexture> CreateAttachedSurfaceTexture(

+ GLuint* service_id) override;

void PostError(const ::tracked_objects::Location& from_here,

media::VideoDecodeAccelerator::Error error) override;

« no previous file with comments | « media/gpu/android_deferred_rendering_backing_strategy.cc ('k') | media/gpu/android_video_decode_accelerator.cc » ('j') | no next file with comments »