Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2005063002: Use vector icon for no unread notifications bell (Closed)

Created:
4 years, 7 months ago by tdanderson
Modified:
4 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, yoshiki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use vector icon for no unread notifications bell Use a vector icon instead of a PNG for the notifications icon shown when there are no unread notifications (bell). Delete the now-unsed image assets with id IDR_ASH_SHELF_NOTIFICATION_TRAY_BELL. BUG=595015, 599891 TEST=manual Committed: https://crrev.com/faa0ab38631cf9aa7e369f7a3e34c1767a61726b Cr-Commit-Position: refs/heads/master@{#395470}

Patch Set 1 #

Patch Set 2 : delete unused pngs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M ash/resources/ash_resources.grd View 1 1 chunk +0 lines, -1 line 0 comments Download
D ash/resources/default_100_percent/common/shelf/notification_tray_bell.png View 1 Binary file 0 comments Download
D ash/resources/default_200_percent/common/shelf/notification_tray_bell.png View 1 Binary file 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
tdanderson
oshima@, can you please take a look?
4 years, 7 months ago (2016-05-23 22:51:58 UTC) #3
oshima
lgtm
4 years, 7 months ago (2016-05-23 22:53:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005063002/20001
4 years, 7 months ago (2016-05-23 22:55:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 23:57:08 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 23:59:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/faa0ab38631cf9aa7e369f7a3e34c1767a61726b
Cr-Commit-Position: refs/heads/master@{#395470}

Powered by Google App Engine
This is Rietveld 408576698